hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Published 20 hours ago • verified publisher icon informalsystems

ICS20 v2 Protobuf encoding

Open ljoss17 opened this issue 7 months ago • 0 comments

Summary

ICS20 v2 will encode packet data using Protobuf instead of JSON https://github.com/cosmos/ibc-go/issues/6630.

Hermes will need to adapt the verification of memo and receiver fields to decode using Protobuf if the transfer is from ICS20 v2, https://github.com/informalsystems/hermes/blob/v1.10.0/crates/relayer/src/link/relay_path.rs#L1956.

Furthermore if the packet is a forward packet, the destination_memo, https://github.com/cosmos/ibc-go/blob/v9.0.0-beta.0/proto/ibc/applications/transfer/v2/packet.proto#L48, should be checked. If not the standard memo should be checked, https://github.com/cosmos/ibc-go/blob/v9.0.0-beta.0/proto/ibc/applications/transfer/v2/packet.proto#L38.

For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate milestone (priority) applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

ljoss17 avatar Jul 23 '24 07:07 ljoss17