hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Add compatibility for ICS20 v2

Open ljoss17 opened this issue 8 months ago • 0 comments

Closes: #4006 Closes: #4098

Description

This PR adds the compatibility for ICS20 v2. This includes:

  • Conditional deserialization of PacketData if the channel version is ics20-1 or ics20-2
  • Update channel Version struct to more easily specify ics20-1 or ics20-2
  • Add test to transfer multiple denom in a single message

Current status of the PR - 30.05.2024

This PR is blocked until a tagged release of ibc-go with ICS20 v2 feature, required for:

  • [ ] Creating new ibc-proto-rs release with ICS20 v2 protos
  • [ ] Adding a new simd to Cosmos Nix to run the Hermes ICS20 v2 test

PR author checklist:

  • [ ] Added changelog entry, using unclog.
  • [ ] Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • [x] Linked to GitHub issue.
  • [ ] Updated code comments and documentation (e.g., docs/).
  • [ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • [ ] Reviewed Files changed in the GitHub PR explorer.
  • [ ] Manually tested (in case integration/unit/mock tests are absent).

ljoss17 avatar May 30 '24 09:05 ljoss17