hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Published 20 hours ago • verified publisher icon informalsystems

Clean up and improve logs

Open romac opened this issue 2 years ago • 2 comments

Closes: #XXX

Description

PR author checklist:

  • [ ] Added changelog entry, using unclog.
  • [ ] Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • [ ] Linked to GitHub issue.
  • [ ] Updated code comments and documentation (e.g., docs/).
  • [ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • [ ] Reviewed Files changed in the GitHub PR explorer.
  • [ ] Manually tested (in case integration/unit/mock tests are absent).

romac avatar Aug 10 '22 08:08 romac

Many CLI have a debug log which contains all the options given, but not all of them have this log. Should we have this log for every CLI or remove it from every CLI ? I do not see a case where this log is very useful, so I tend to be of the opinion to remove it from the CLIs. https://github.com/informalsystems/ibc-rs/blob/romac/cleanup-logs/relayer-cli/src/commands/query/client.rs#L122-L124

ljoss17 avatar Aug 10 '22 15:08 ljoss17

I do not see a case where this log is very useful, so I tend to be of the opinion to remove it from the CLIs.

Agreed!

romac avatar Aug 10 '22 15:08 romac