hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Light client extraction (long-lived branch)

Open hu55a1n1 opened this issue 2 years ago • 0 comments

Closes: #2338

Description

This is the PR for merging the long-lived branch for ADR011 impl.

Make sure the following points are addressed before merging ->

  • [ ] ChannelReaderLightClient is a supertrait of ChannelReader. (see comment -> https://github.com/informalsystems/ibc-rs/pull/2332#discussion_r932524874)
  • [ ] Remove encode_vec()
  • [ ] Add CI test for dummy light client that is hosted in an external crate (similar to https://github.com/informalsystems/ibc-rs/tree/master/ci/no-std-check).

PR author checklist:

  • [ ] Added changelog entry, using unclog.
  • [ ] Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • [ ] Linked to GitHub issue.
  • [ ] Updated code comments and documentation (e.g., docs/).
  • [ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • [ ] Reviewed Files changed in the GitHub PR explorer.
  • [ ] Manually tested (in case integration/unit/mock tests are absent).

hu55a1n1 avatar Jul 29 '22 16:07 hu55a1n1