hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Published 20 hours ago • verified publisher icon informalsystems

Allow the host implementation to specify the `generateIdentifier` function for connection and channel identifiers

Open hu55a1n1 opened this issue 2 years ago • 1 comments

Summary of Bug

We currently define trait methods like ConnectionReader::connection_counter() and use them to generate the connection identifier -> https://github.com/informalsystems/ibc-rs/blob/57b8af939eedab3a5ad55d7045a108ed0dfab1f6/modules/src/core/ics03_connection/handler/conn_open_init.rs#L42-L44

This restricts host implementations' ability to generate custom identifiers and is a deviation from the spec.

Version

v0.16.0

Acceptance Criteria

Either provide a way for host impls to specify their own generateIdentifier or document this as a divergence (in divergence from the ICS).

For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate milestone (priority) applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

hu55a1n1 avatar Jun 29 '22 08:06 hu55a1n1