hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Automate patching of proto files

Open hu55a1n1 opened this issue 2 years ago • 0 comments

Summary

The proto files generated by the proto-compiler do not compile out-of-the-box (see https://github.com/informalsystems/ibc-rs/issues/1374). They also include some unused files (see comment from @mzabaluev https://github.com/informalsystems/ibc-rs/pull/2278#pullrequestreview-1000923095). We currently fix these problems manually but would be great if we could automate them.

Proposal

We could update the sync-protobuf.sh script or the Proto-compiler crate to automatically fix these problems.

Acceptance Criteria

The patching process is automated.


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate milestone (priority) applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

hu55a1n1 avatar Jun 09 '22 10:06 hu55a1n1