hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Packet proof of `TimeoutOnClose` packets for ordered channels is wrong

Open plafer opened this issue 2 years ago • 0 comments

Summary of Bug

Looking at ChainEndpoint::proven_packet(PacketMsgType::TimeoutOnClose) for CosmosSdkChain, we build a ReceiptPath, which is only correct if the channel is unordered. For ordered channels, we should query the SeqRecvsPath to build the proof.

@ancazamfir:

indeed we need to do like this for this case.

Version

v0.15.0


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate milestone (priority) applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

plafer avatar May 27 '22 16:05 plafer