hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Improvement suggestions to the `conclude` module

Open seanchen1991 opened this issue 4 years ago • 2 comments

Summary

Some suggestions for improvements to the conclude.rs module, notably adding colors to the status types (red for Error, green for Success, etc.) as well as adding an Info status type.

Problem Definition

While working on #2014, I found myself wanting to output terminal output that didn't fit neatly into either Success or Error status types. These would have been appropriate being displayed via something like Output::info. Would it be appropriate to add this as a status type?

Additionally, it would be nice to add colors to the terminal output, i.e. red for Error output and green for Success output (Info would be colored blue) in order to match the colors that the logs exhibit. This can be easily done with the console crate.

Proposal

Add an Info status type to the conclude module, as well as add color styling to the status types.

Acceptance Criteria

  • [ ] Add Info status type
  • [ ] Add color styling to status types

For Admin Use

  • [x] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate milestone (priority) applied
  • [x] Appropriate contributors tagged
  • [x] Contributor assigned/self-assigned

seanchen1991 avatar Mar 25 '22 17:03 seanchen1991

Pinging @mzabaluev in particular as the author of the conclude module.

seanchen1991 avatar Mar 25 '22 17:03 seanchen1991

@seanchen1991 I should take a look, but note that I'm not the author of the majority of the code.

mzabaluev avatar Apr 04 '22 11:04 mzabaluev