hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Consider switching away from rouille

Open mzabaluev opened this issue 3 years ago • 1 comments

Crate

ibc-relayer-rest, ibc-telemetry

Summary

The rouille crate imposes an unnecessary restriction on its time dependency, holding back useful changes.

Problem Definition

The crates depend on rouille, which pins its dependency on time to =0.3.2: https://github.com/tomaka/rouille/issues/246

This will come into conflict with changes made in https://github.com/informalsystems/tendermint-rs/pull/1030 and has already caused a rollback in https://github.com/informalsystems/tendermint-rs/issues/1047.

Proposal

Switch to warp, or any other suitable web service framework without dependency issues.

Acceptance Criteria

The problem is resolved upstream, or this project removes the rouille dependency.


For Admin Use

  • [x] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate milestone (priority) applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

mzabaluev avatar Dec 08 '21 14:12 mzabaluev

Once #1665 is in, rouille will be the last obstacle to fixing #1478.

mzabaluev avatar Dec 13 '21 16:12 mzabaluev