enterprise icon indicating copy to clipboard operation
enterprise copied to clipboard

Editor: Insert Image doesn't work when adding attributes

Open radovaniljic opened this issue 2 years ago • 3 comments

Describe the bug Insert Image doesn't work when adding extra attributes to the editor.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://stackblitz.com/edit/ids-quick-start-1431-ykiuma?file=src/app/app.component.ts
  2. Click on "Insert Image" in the editor toolbar.
  3. Enter a valid url to an image, e.g. https://www.infor.com/img/logo-infor.png
  4. Click "Insert"

Expected behavior The image should be inserted into the editor.

Version

  • ids-enterprise: 4.67.1

Screenshots bild

Platform

  • Infor Application/Team Name: Infor OS

radovaniljic avatar Sep 29 '22 10:09 radovaniljic

Hmm they shouldnt have anything to do with each other. I do see an image is inserted but its just <img>. Do you think it could be a cross site issue?

tmcconechy avatar Sep 29 '22 13:09 tmcconechy

Oh yeah I forgot to mention that <img> is inserted. It works when you don't add attributes though and I see here that attributes are checked when inserting an image so maybe there's an issue there?

radovaniljic avatar Sep 29 '22 15:09 radovaniljic

Ok that line is definitely the issue. I think we need to be more specific there on which attributes it uses

tmcconechy avatar Sep 29 '22 16:09 tmcconechy

QA Passed. Verified in https://main-enterprise.demo.design.infor.com/components/editor/test-image-attribute.html. Thanks! image

janahintal avatar Nov 10 '22 13:11 janahintal