enterprise icon indicating copy to clipboard operation
enterprise copied to clipboard

Locale: Incorrect "Previous" translation in Slovenian

Open cpinatel7 opened this issue 2 years ago • 14 comments

Locale: Incorrect "Previous" translation in Slovenian

image

image

Please assign to [email protected] for review

cpinatel7 avatar Aug 17 '22 16:08 cpinatel7

cc @hwondergem

tmcconechy avatar Aug 17 '22 16:08 tmcconechy

Hi, feedback from the translator: "The standard way of translation for “Previous” in these kind of contexts is “Nazaj” (i.e., as it is already). This is both gender and number neutral, since it is often not known what the subject will be (i.e., previous what?). So, unless it is known what the previous thing is and that this particular instance of “previous” will only be used here (where the gender and number is known), then I would suggest the translations remains as it is. Also, the translation of “previous” depends on how “next” is translated in this context, so I would need to know that, before any change can be made."

hwondergem avatar Sep 06 '22 14:09 hwondergem

Ok @hwondergem i think for purposed of the component library we should translate this as "Database Records" but not anything specific.

However, for the team in this case (since its on a header and not the datagrid or a list of records) they could request a specific translation for the type of object for the app? @cpinatel7

Does the current translation match to something generic like "Database Records"?

tmcconechy avatar Sep 06 '22 14:09 tmcconechy

Additional screenshot - to be reviewed by SL linguist: image

Are your Previous and Next strings always used in the same context?

cpinatel7 avatar Sep 06 '22 14:09 cpinatel7

yeah i guess so they are just previous and next from the context of a generic pager https://main-enterprise.demo.design.infor.com/components/pager/example-datagrid.html where we dont really know what data is in the pager.

These look like your moving through records on on a header but same idea. I guess you could translate it for what your moving through but we would never know so need to keep it generic as it could be any data....

tmcconechy avatar Sep 06 '22 14:09 tmcconechy

I don't speak SL but in this case, translations should be neutral (i.e. not gender specific). Ideally, Next should be Next Record and Previous should be Previous Record. This will avoid future translation issues. Thanks

cpinatel7 avatar Sep 06 '22 14:09 cpinatel7

Sounds like it is that way from @hwondergem 's comment:

This is both gender and number neutral, since it is often not known what the subject will be (i.e., previous what?)

tmcconechy avatar Sep 06 '22 14:09 tmcconechy

Would it be possible to change the English strings at some point? i.e. Next -> Next Record and Previous -> Previous Record

cpinatel7 avatar Sep 06 '22 14:09 cpinatel7

Yes, @cpinatel7 if you think that makes sense for "any pager next/previous no matter what the data"? I can do that, think here as one example https://main-enterprise.demo.design.infor.com/components/pager/example-datagrid.html but also on that header as that team has done

tmcconechy avatar Sep 06 '22 14:09 tmcconechy

No changes required for: (context is clear) image

I cannot see Previous and Next on https://main-enterprise.demo.design.infor.com/components/pager/example-datagrid.html

I think there are 2 options:

  1. Source text changes: Next -> Next Record and Previous -> Previous Record
  2. If 1. is too risky, the string comments should indicate that Next and Previous can be used in different contexts

Option 1 is definitely much better.

Thanks

cpinatel7 avatar Sep 06 '22 15:09 cpinatel7

ok we can make this change...

tmcconechy avatar Sep 06 '22 15:09 tmcconechy

Thanks

cpinatel7 avatar Sep 06 '22 15:09 cpinatel7

After discussing this we would like to keep this text is shorter. Can just translate it as if it actually said "page" for the gender?

tmcconechy avatar Sep 28 '22 13:09 tmcconechy

Next and Previous are not related to Page. They are related to Record i.e. Next -> Next Record and Previous -> Previous Record. I'm not sure why tooltips have to be short: image

cpinatel7 avatar Sep 28 '22 14:09 cpinatel7

@cpinatel7 will this work?

  • use "next page", "previous page" for the pager (where it already says page)
  • make an example with arrows on the header (tooltip custom that says next record/previous record)
  • add strings if not there for next / previous record

tmcconechy avatar Mar 31 '23 16:03 tmcconechy

Overall, "Next" and "Previous" should be avoided:

  • Page context, "Next Page" and "Previous Page" should be used instead
  • Record context, "Next Record" and "Previous Record" should be used instead

If "Next" and "Previous" strings cannot be removed, could you please add comments stating that these strings can be used in DIFFERENT contexts. Next = A navigation control used to go to the next page / record / item, etc. Previous = A navigation control used to go to the previous page / record / item, etc.

Thanks

cpinatel7 avatar Apr 04 '23 11:04 cpinatel7

Ok done. Added these here: https://github.com/infor-design/enterprise-wc/pull/1218 and on the server for translation.

Once translated will use Next Page/Previous Page for the pager component but you can use Next/Previous Record as you wish on the page/toolbar...

Kept next/previous but not sure we will use it for anything going forward

tmcconechy avatar Apr 04 '23 14:04 tmcconechy

Thanks

re: Kept next/previous but not sure we will use it for anything going forward

Is it possible to add comments for these strings stating that they are used in DIFFERENT contexts. Next = A navigation control used to go to the next page / record / item, etc. Previous = A navigation control used to go to the previous page / record / item, etc.

cpinatel7 avatar Apr 04 '23 14:04 cpinatel7

I did add some comments here https://github.com/infor-design/enterprise-wc/pull/1219/files#diff-4a4e435ae780de2644009d72d9521f252dbd50337dc0102788a7510164f08e1dL347

Maybe you can edit the PR with the comments you want? Click in the gutter on the left and make suggestion?

Screenshot 2023-04-04 at 10 58 48 AM

tmcconechy avatar Apr 04 '23 14:04 tmcconechy

Thanks. "Generic Next for a tooltip" and "Generic Previous for a tooltip" are fine

cpinatel7 avatar Apr 04 '23 15:04 cpinatel7

As of 4.83 we now have two strings which can be selected from however these do not appear to be translated on the latest drop in Slovenian / sl-SL yet PreviousRecord and NextRecord are missing

Next: { id: 'Next', value: 'Next', comment: 'Generic Next for a tooltip, see Next Record and Next Page for more specific' },
 NextMonth: { id: 'NextMonth', value: 'Next Month', comment: 'the label for the button that moves calendar to next/prev' },
 NextPage: { id: 'NextPage', value: 'Next Page', comment: 'Move to next item on Pager component' },
 NextRecord: { id: 'NextRecord', value: 'Next Record', comment: 'Can be used as a tooltip for arrow navigation on a form moving between records' },
 Previous: { id: 'Previous', value: 'Previous', comment: 'Generic Previous for a tooltip, see Next Record and Next Page for more specific' },
  PreviousMonth: { id: 'PreviousMonth', value: 'Previous Month', comment: 'the label for the button that moves calendar to next/prev' },
  PreviousPage: { id: 'PreviousPage', value: 'Previous Page', comment: 'Move to next item on Pager component' },
  PreviousRecord: { id: 'PreviousRecord', value: 'Previous Record', comment: 'Can be used as a tooltip for arrow navigation on a form moving between records' },
  PreviousWeek: { id: 'PreviousWeek', value: 'Previous Week', comment: 'the label for the button that moves calendar to next/prev' },
  PreviousYear: { id: 'PreviousYear', value: 'Previous Year', comment: 'the label for the button that moves calendar to next/prev' },

tmcconechy avatar May 16 '23 15:05 tmcconechy

Translations updated in ..cc\ToDev\SohoUX\sl-SI-messages.ts 61,621 07/19/2023 06:46 Like: Next: { id: 'Next', value: 'Naslednji', comment: 'Generic Next for a tooltip, see Next Record and Next Page for more specific' }, NextMonth: { id: 'NextMonth', value: 'Naslednji mesec', comment: 'the label for the button that moves calendar to next/prev' }, NextPage: { id: 'NextPage', value: 'Naslednja stran', comment: 'Move to next item on Pager component' }, NextRecord: { id: 'NextRecord', value: 'Naslednji zapis', comment: 'Can be used as a tooltip for arrow navigation on a form moving between records' },

hwondergem avatar Jul 26 '23 08:07 hwondergem