enterprise icon indicating copy to clipboard operation
enterprise copied to clipboard

Published 20 hours ago • verified publisher icon infor-design

6686 - Searchfield visual bugfix

Open yohannahbautista opened this issue 2 years ago • 5 comments

Explain the details for making this change. What existing problem does the pull request solve?

  • Adjusted border in searchfield so that height is even
  • Added check for searchfield go button on changing buttonset width

Related github/jira issue (required):

Closes #6686

Steps necessary to review your pull request (required):

  • Pull this branch, build and run the app
  • Go to: http://localhost:4000/components/tabs-module/example-category-searchfield-go-button-home.html

On uneven searchfield height:

  • Click on the searchfield to focus it
  • Click anywhere else on the page

On cut off go button:

  • Resize the window small enough where the searchfield collapses
  • Expand the window with the maximize button

Included in this Pull Request:

  • [ ] A note to the change log.

yohannahbautista avatar Aug 10 '22 10:08 yohannahbautista

Fix for build issue https://github.com/infor-design/enterprise/pull/6724 FYI

ericangeles avatar Aug 10 '22 13:08 ericangeles

Not sure if this is ready to review but seeing a few odd things.

  1. on reduced width the buttons flow funny and the text is cut off (i think the example should use toolbar-flex to fix some of this) Screen Shot 2022-08-10 at 10 17 01 AM

  2. The focus state on the category button and go button isnt visible or shows a slight border change only

  3. keep reloading the page and you see the search field move around into place (might also be fixed by changing to toolbar-flex in the example)

tmcconechy avatar Aug 10 '22 14:08 tmcconechy

Hi @tmcconechy,

Is it possible that this gets fixed without changing the sample to use toolbar-flex? This could be a possibility in the future, but right now it would be too close to our code cutoff to switch to a different component.

s-werking avatar Aug 10 '22 15:08 s-werking

I dont think so, maybe the shape of the search field might be ok without it but I doubt we can fix:

  • the text getting cut off on the toolbar title
  • the loading behavior
  • and some width/resizing behavior (possible)

I would suggest we make the example look right with the new toolbar code and include the example with the old toolbar code (so include both) and get it mostly right but still may be toolbar issues with using the old toolbar

tmcconechy avatar Aug 10 '22 15:08 tmcconechy

Sounds good, thank you!

s-werking avatar Aug 10 '22 15:08 s-werking

New PR here: https://github.com/infor-design/enterprise/pull/6824

yohannahbautista avatar Sep 15 '22 09:09 yohannahbautista