Locale: Exclamation mark should be displayed on the right-hand side in all languages

[cpinatel7]

Exclamation mark should be displayed on the right-hand side in all languages

• English: Exclamation mark is displayed on the right-hand side
• Languages: Exclamation mark is displayed on the left-hand side

Example: English vs Russian

From GRC dev:

We have reproduced the issue in below fork code:

https://github.com/JangleShubham/enterprise-ng.git

Please go to http://localhost:4200/ids-enterprise-ng-demo/tabs-vertical after running this project and go into Contract tab, create validation error, it will show exclamation error icon at left side.

Please see attachment for more detail.

Please ask enterprise team to follow above steps to reproduce the issue.

[tmcconechy]

As a note i can't reproduce this on the example we have:

https://main-enterprise.demo.design.infor.com/components/validation/test-error-on-tab-vertical.html?locale=ru-RU and https://main-enterprise.demo.design.infor.com/components/validation/test-error-on-tab-vertical.html?locale=en-US

I cant seem to run your project its giving a ton of errors.... Perhaps you can put it in https://stackblitz.com/edit/ids-quick-start-940 (make a fork and add the code). Or perhaps you can try a newer version?

[cpinatel7]

From: Shubham Jangle [email protected] Sent: vendredi 23 avril 2021 05:49 To: Christophe Louis Pinatel [email protected] Subject: RE: [infor-design/enterprise] Locale: Exclamation mark should be displayed on the right-hand side in all languages (#5119)

Hello Christophe,

I guess issue is there in provided links by Tim https://main-enterprise.demo.design.infor.com/components/validation/test-error-on-tab-vertical.html?locale=ru-RU and https://main-enterprise.demo.design.infor.com/components/validation/test-error-on-tab-vertical.html?locale=en-US For all languages including en-US exclamation error icon is appearing at left side in above examples and also in GRC as well.

Can you please check? Or the issue is something different(I might be thinking of something else)

Thanks, Shubham Jangle

[tmcconechy]

Yes the icon seems to appear on the left side? Is there anything wrong with that? For example anything from a translation point of view?

[cpinatel7]

It's a minor issue but there is no justification / requirement to display ! on the right in English and on the left in languages. It should be on the right-hand side. Thanks

[tmcconechy]

Ok agreed it probably makes sense on the right

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[cpinatel7]

Still valid. Thanks

[tmcconechy]

@cpinatel7 i think we need to know what languages in our set should be on the right and which should be on the left? Is this a true statement: Its on the left in English and EVERY other language its on the right?

[cpinatel7]

I think we need to understand the logic first. Example: In English? Why one ! on the left and one ! on the right? What's the logic? Thanks

[tmcconechy]

@cpinatel7 there really isnt any logic to these. But for the input field i think its common to put the error at the front of the text unless its Right To Left. But for the tab error we could put it on either side (design desicion).

So i think for both cases we should just have the error on the left unless its a RTL language? Unless there are language concerns with either?

One other factor is there needs to be room for it on the left so thats why in some cases we stick it on the right.

From your side can you see any translation recommendations on this as im not really sure we have logic and its well thought out so we can do it how makes sense

[cpinatel7]

My recommendation is to be consistent. Same approach in all languages including English. In short, I agree with your statement "i think for both cases we should just have the error on the left unless its a RTL language".

I think an exclamation point sign in red triangle would be better than the current icon (the current icon is quite similar to a standard exclamation mark so positioning it on the left is a bit confusing)

[ericangeles]

@tmcconechy, do you think we should ask for design feedback here?

[tmcconechy]

For the icon change i dont think we want to change the icon. I think its as expected. But we can check with @talkaboutdesign what do you think about making the tab errors on the left?