enterprise-ng icon indicating copy to clipboard operation
enterprise-ng copied to clipboard

Datagrid: Nested datagrid disappears after render

Open dmcodrum opened this issue 1 year ago • 8 comments

Describe the bug Expanded/nested datagrid not working after upgrade from IDS NG 16 to 17.

I am unable to recreate this in test or stackflow environment with a simple example but Tim is aware of the details of this issue.

To Reproduce Steps to reproduce the behavior:

  1. In our application (GLT), open a 'Material Content Report'
  2. In the datagrid click one of the expanders.
  3. The nested inside datagrid appears for a brief moment and then disappears. There is still an empty space where the inside grid should still be showing.

Expected behavior The inside grid should remain visible

Version

  • ids-enterprise-ng: 17.x

Platform

  • OS Version: Windows 11
  • Browser Name: chrome
  • Browser Version: 122.0.6261.129

Additional context In discussion with Tim , we believe that this bug may be caused by these fixes: https://github.com/infor-design/enterprise/pull/8070/files and/or https://github.com/infor-design/enterprise-ng/pull/1464/files In our application the nested datagrid is an Angular component.

dmcodrum avatar Mar 19 '24 18:03 dmcodrum

Hi @dmcodrum - Please provide an environment for to reproduce this issue. We will reach out separately for the credentials.

AAlviar avatar Mar 27 '24 12:03 AAlviar

I'll let you know when I have something setup. Thanks!

On Wed, Mar 27, 2024 at 8:42 AM AAlviar @.***> wrote:

Hi @dmcodrum https://github.com/dmcodrum - Please provide an environment for to reproduce this issue. We will reach out separately for the credentials.

— Reply to this email directly, view it on GitHub https://github.com/infor-design/enterprise-ng/issues/1656#issuecomment-2022673427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJLVVFU3F77VNPIUW36YPPLY2K5D3AVCNFSM6AAAAABE6DV6Z6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRSGY3TGNBSG4 . You are receiving this because you were mentioned.Message ID: @.***>

dmcodrum avatar Mar 27 '24 12:03 dmcodrum

Where's the test page for this one? @AAlviar

tjamesallen15 avatar May 03 '24 02:05 tjamesallen15

This one is complicated @tjamesallen15 you will have to look at some setup that @dmcodrum provides and try and debug it and see if you can figure out the issue.

cc @AAlviar

Maybe the fix might be something like making sure https://github.com/infor-design/enterprise/pull/8070/files#diff-13c32b0c73b40992aa6d376fb22d6746845a3b7d6d2545e19bd30687bcabb5a5R4417 only fires once per render for expandable areas..

tmcconechy avatar May 03 '24 13:05 tmcconechy

@tjamesallen15 - like Tim said, this is a difficult one to create a test case for. My idea is for us to have a Teams call so I can show you the issue. Likewise, you can run/debug in a remote session on my machine. Please schedule a call to discuss to fit your availability. You can see my calendar on outlook - [email protected]. I'm EST. Thanks!

dmcodrum avatar May 03 '24 14:05 dmcodrum

@tjamesallen15 - like Tim said, this is a difficult one to create a test case for. My idea is for us to have a Teams call so I can show you the issue. Likewise, you can run/debug in a remote session on my machine. Please schedule a call to discuss to fit your availability. You can see my calendar on outlook - [email protected]. I'm EST. Thanks!

I messaged you on teams so that we can test about this topic.

tjamesallen15 avatar May 07 '24 09:05 tjamesallen15

Update:

@dmcodrum and I checked up the bug and I have an initial code change for this one. I will just test this on our code base to see if any will issue will arise.

cc @tmcconechy @ericangeles

tjamesallen15 avatar May 10 '24 07:05 tjamesallen15

Made a PR for this one, cross tested with @dmcodrum via call

tjamesallen15 avatar May 24 '24 05:05 tjamesallen15