enterprise-ng icon indicating copy to clipboard operation
enterprise-ng copied to clipboard

SohoDataGrid: expose `updateDataset` API

Open ahnpnl opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe.

Comparing between https://github.com/infor-design/enterprise-ng/blob/28476ce4d4268fcaa92d5271797f074e1ad9c515/projects/ids-enterprise-typings/lib/datagrid/soho-datagrid.d.ts#L1002 vs https://github.com/infor-design/enterprise-ng/blob/28476ce4d4268fcaa92d5271797f074e1ad9c515/projects/ids-enterprise-ng/src/lib/datagrid/soho-datagrid.component.ts#L143 , updateDataset API is not exposed for SohoDatagridComponent, hence it is not possible to get IDE suggestion to use it.

Describe the solution you'd like

Expose updateDataset API for SohoDatagridComponent in ids-enterprise-ng.

Describe alternatives you've considered

I don't know any workarounds

Additional context

I'm not sure if any other APIs are missing for SohoDatagridComponent or not but perhaps all APIs should be checked to see if anything is missing.

ahnpnl avatar Apr 12 '21 15:04 ahnpnl

Ok i see what you meant in the thread now. I think the person that setup SohoDatagrid just called it data.

https://github.com/infor-design/enterprise-ng/blob/28476ce4d4268fcaa92d5271797f074e1ad9c515/projects/ids-enterprise-ng/src/lib/datagrid/soho-datagrid.component.ts#L961

So you can use it there. Wonder if there is value in exposing the other one too so its a one to one mapping.

tmcconechy avatar Apr 12 '21 16:04 tmcconechy

I find it quite convenient to have 1-1 mapping from design.infor.com to ng wrapper. That makes it easier to use :) I myself often doing that way, first going to design.infor.com to find the API I need and then i look into the ng wrapper to find, straight forward.

ahnpnl avatar Apr 12 '21 17:04 ahnpnl

Agreed - if you wanted to PR it i'd accept it - otherwise will get to this when i can

tmcconechy avatar Apr 12 '21 17:04 tmcconechy

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

github-actions[bot] avatar May 21 '24 01:05 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Jun 04 '24 01:06 github-actions[bot]