web-search-navigator icon indicating copy to clipboard operation
web-search-navigator copied to clipboard

Enhancement: Add "SHIFT-downarrow" and "SHIFT-uparrow" to navigate through the "More results from..." section

Open afilp opened this issue 6 years ago • 9 comments

May I recommend that we also add "SHIFT-downarrow" and "SHIFT-uparrow" to navigate through the "More results from..." section?

image

afilp avatar Dec 02 '18 11:12 afilp

Sounds good. I plan to expand the navigation in the next batch of improvements I'll make (not sure when yet), including stuff mentioned in #92

infokiller avatar Dec 02 '18 12:12 infokiller

With #94 it is possible to navigate to subresults and "more results from..." or whatever using the default browser focus shortcuts - tab key and shift+tab. It works pretty well for me for this kind of links. It is not so good for - for example - twitter entries mentioned in #92, because there is a lot of "focusable-element noise".

mancze avatar Dec 03 '18 09:12 mancze

@mancze I understand this and I do use the tab but it is not as an instant experience.

Because we already have our fingers in the arrow keys. With the shift-arrows proposal (which are not used for something else fortunately) it is as easy as holding the shift button while pressing the down arrow on the 1st result.

afilp avatar Dec 03 '18 10:12 afilp

@afilp another option is to use home row keys for everything. For example, I use ijkl for results navigation instead of the arrow keys, and space to open a link. I find this pretty comfortable.

infokiller avatar Dec 15 '18 19:12 infokiller

@infokiller Now I am also using j/k, it is very convenient indeed. So, how about having "SHIFT-j" and "SHIFT-k" for navigating through the "More results from..." section?

Also, will you upload a new version on Chrome Extensions? Thanks a lot!

afilp avatar Jun 02 '19 01:06 afilp

@infokiller Now I am also using j/k, it is very convenient indeed. So, how about having "SHIFT-j" and "SHIFT-k" for navigating through the "More results from..." section?

There are two separate things here:

  1. Adding the ability to navigate "subresults"
  2. Setting the default keybindings for "subresults" navigation

I'm fine with merging a PR for (1), but (2) will need more consideration. That said, if (1) is merged you will be able to set the keybindings in the options, so you shouldn't be too worried about (2) for your use case.

Also, will you upload a new version on Chrome Extensions? Thanks a lot!

I want to do it in the next few weeks, but can't commit to anything.

infokiller avatar Jun 02 '19 06:06 infokiller

This is a great extension, but not being able to get to these other links is the biggest problem for me.

I do not mind using TAB and SHIFT-TAB to navigate to these links, but when I press ENTER, what happens is that that link will be activated at the same time as the link that this extension is marking, which then opens.

Is there any way of deactivating the extension momentarily?

eggbean avatar Apr 09 '20 05:04 eggbean

@eggbean indeed I just tested this and it seems there's a bug (regression following the fix). There's no way to momentarily deactivate the extension. I'll try to fix this ASAP.

infokiller avatar Apr 10 '20 12:04 infokiller

~~@eggbean can you please test this again? it works for me now~~ Update: sorry this has already been verified to work

infokiller avatar Sep 05 '21 14:09 infokiller