web-search-navigator icon indicating copy to clipboard operation
web-search-navigator copied to clipboard

feat(SearchEngine): Add Gitlab instances

Open Syndlex opened this issue 2 years ago • 7 comments

So I added Gitlab as a search engine.

It also contains the code for custome Gitlab instances. The problem is that I could not get optional_permissions working with custom URLs added by the Settings UI. Maybe someone with more knowledge about browser extensions can get it to work.

I love this extension and would love to use the workflow on a company gitlab.

Syndlex avatar Aug 05 '22 18:08 Syndlex

Thanks for the PR! I'll add a few comments to the PR, but A few general ones:

  • Remove unrelated formatting changes
  • Fix formatting issues (see CodeFactor report) and verify yarn run check has no errors
  • Add an entry to the CHANGELOG

infokiller avatar Aug 05 '22 20:08 infokiller

I still see some unrelated formatting changes and incorrect formatting? does yarn check pass?

infokiller avatar Aug 06 '22 11:08 infokiller

This pull request introduces 1 alert when merging 5755e8e464c4a1d9ce19180f142f5fd4e1a9c0a6 into 8d99324c9a144d2774d8d04a2234092e997a855e - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 27 '22 21:08 lgtm-com[bot]

I divided up the custom instance and the normal instance.

Hope this is ok. There is no other way to implement websites on runtime.

Syndlex avatar Aug 27 '22 21:08 Syndlex

This pull request introduces 1 alert when merging 66e011c77ebe1d7bcc9bfa9e6346140c41536347 into 8d99324c9a144d2774d8d04a2234092e997a855e - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 27 '22 21:08 lgtm-com[bot]

I divided up the custom instance and the normal instance.

Hope this is ok. There is no other way to implement websites on runtime.

Yes, this is fine

infokiller avatar Aug 28 '22 11:08 infokiller

Just to let you know that I haven't forgotten about this PR, I just want to test it manually before I merge it, will do it "soon"

infokiller avatar Sep 04 '22 20:09 infokiller

@Syndlex I merged the changes locally, fixed some conflicts and issues, and added regex validation. I accidentally closed this PR because I pushed the master branch to your fork. Let's continue in #525

infokiller avatar May 29 '23 08:05 infokiller