telegraf icon indicating copy to clipboard operation
telegraf copied to clipboard

chore(outputs.mqtt): Rework templating to use TemplateMetric

Open Hipska opened this issue 10 months ago • 2 comments

Summary

The topic_prefix parameter is deprecated and will get removed in v1.35, so I updated the docs to not mention it anymore. In the meantime, I also migrated the custom template names to make use of the already existing TemplateMetric functionality.

This will also make the removal of TopicPrefix and TopicNameGenerator easier in the future. As an example, the HomieGenerator is already completely replaced.

Checklist

  • [x] No AI generated code was used in this PR

Related issues

resolves #

Hipska avatar Feb 25 '25 16:02 Hipska

Cypress is an extension on chrome. I was running into the same issue and getting 503. I fixed it by enabling permissions on the extension. Upper right hand where the three dots for settings screen shot 2017-10-19 at 9 37 55 pm go to extensions and allow permissions screen shot 2017-10-19 at 9 37 35 pm

screen shot 2017-10-19 at 9 39 47 pm

vjefri03 avatar Oct 20 '17 04:10 vjefri03

@pawelgalazka @brian-mann @jennifer-shehane I've never seen node processes look to the OS proxy configuration. Not saying that you can't expose OS configurations, but it's far more typical to see rc or pick your favorite shell export these to the runtime.

In my own employer's environment, besides SOCKS being strictly locked down, the OS proxy is not exposed to node and every developer has documentation to set up their shell, e.g., .zshenv, correctly.

Additionally, SOCKS support does not look like something out of the box for node, requiring a module. node supports most http_proxy variables.

timothystone avatar Nov 12 '17 14:11 timothystone

Seems like this is node-specific.

  • Setting browser SOCKS5 proxy via extension still fails, but accessing my resource on another tab of Cypress-launched browser works.
  • Setting http_proxy env to use socks5 or socks5h will spit out error during test run:
Error: Invalid protocol: socks5h:
    at Request.init (/Users/syazwan/Library/Caches/Cypress/3.1.0/Cypress.app/Contents/Resources/app/packages/server/node_modules/request/request.js:454:31)

So node itself is not using proxy settings from extension. With the env set, other CLI like curl works as expected, but not Cypress.

asyazwan avatar Sep 27 '18 07:09 asyazwan

Since this issue hasn't had activity in a while, we'll close the issue until we can confirm this is still happening. Please comment if there is new information to provide concerning the original issue and we'd be happy to reopen.

jennifer-shehane avatar Apr 08 '22 13:04 jennifer-shehane

is it fixed? or socks5 proxy cannot be just used with cypress?

dejwsz avatar Aug 30 '24 09:08 dejwsz

@dejwsz I did not confirm. We haven't had comments on this issue in years, so hopefully it is fixed.

jennifer-shehane avatar Aug 30 '24 18:08 jennifer-shehane

Well, after my tests with latest cypress it looks like it isn't. Finally I have just used another proxy so when you have already working socks5 proxy you can add another http -> socks5 one and configure cypress with it. And it works fine. So there is no direct support for socks5 as I found. I have used python's pproxy: https://pypi.org/project/pproxy/. Additionally for the node itself I had set: "npm config set proxy http://localhost:8080" before executing cypress process. For cypress I set such envs: --env HTTP_PROXY=http://localhost:8080,HTTPS_PROXY=http://localhost:8080,NO_PROXY=localhost Important thing to me was to send also DNS requests via it what is possible over socks5 and pproxy supports it too over http.

dejwsz avatar Aug 31 '24 16:08 dejwsz

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

cypress-app-bot avatar Mar 03 '25 02:03 cypress-app-bot

This issue has been closed due to inactivity.

cypress-app-bot avatar Mar 17 '25 02:03 cypress-app-bot