telegraf icon indicating copy to clipboard operation
telegraf copied to clipboard

feat(serializer.prometheusremotewrite): output native histogram

Open Reimirno opened this issue 11 months ago • 2 comments

Summary

Be able to output prom native histogram when necessary fields are present.

Checklist

  • [ ] No AI generated code was used in this PR

Related issues

resolves #16120

Reimirno avatar Feb 10 '25 06:02 Reimirno

I will review this after we go the serializer in #16493 merged...

srebhan avatar Feb 17 '25 16:02 srebhan

For sure, thank you.

Reimirno avatar Feb 23 '25 04:02 Reimirno

@Reimirno could you please tick the checkbox No AI generated code was used in this PR in the PR description as we otherwise cannot review the code. Furthermore, please take a look at the linter warnings!

srebhan avatar Mar 07 '25 10:03 srebhan

Yup, thank you. I will take another look at this one later. Will tag you when this is ready to be looked at :)

Reimirno avatar Mar 10 '25 04:03 Reimirno

@Reimirno any chance you work on this PR?

srebhan avatar Apr 08 '25 12:04 srebhan

Thanks for checking in. I'd love to iterate on this, will try to get to it this month...

Reimirno avatar Apr 10 '25 05:04 Reimirno

Finally got the chance to iterate on it; @srebhan thank you so much for the thoughtful feedback!

the only CI broken is the same as this one which already get fixed in master; I would ignore.

Reimirno avatar May 08 '25 07:05 Reimirno

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.

:partying_face: This pull request decreases the Telegraf binary size by -1.67 % for linux amd64 (new size: 284.0 MB, nightly size 288.8 MB)

:package: Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

telegraf-tiger[bot] avatar May 08 '25 07:05 telegraf-tiger[bot]