telegraf icon indicating copy to clipboard operation
telegraf copied to clipboard

fix(inputs.mysql): MariaDB example to include mariadb_dialect (#16159)

Open grooverdan opened this issue 1 year ago • 4 comments

Summary

Docker-compose example for inputs.mysql for the MariaDB didn't include mariadb_dialect = true. As all maintained versions of MariaDB are 10.5 it seemed prudent to include.

Also it was possible for telegraf to start before MariaDB was ready. Use the healthcheck mariadb has to ensure that docker compose orders this correctly.

The mariadb container can take straight command line arguments and this will pass though to the mariadb server (mariadbd).

Checklist

  • [x] No AI generated code was used in this PR

Related issues

resolves #16159

grooverdan avatar Nov 07 '24 01:11 grooverdan

Thanks so much for the pull request! :handshake: :black_nib: Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

telegraf-tiger[bot] avatar Nov 07 '24 01:11 telegraf-tiger[bot]

!signed-cla

grooverdan avatar Nov 07 '24 01:11 grooverdan

Sure, can you point me towards the integration tests?

grooverdan avatar Nov 07 '24 17:11 grooverdan

Basically every test in mysql_test.go having a Integration suffix e.g. this one...

srebhan avatar Nov 07 '24 17:11 srebhan

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you!

telegraf-tiger[bot] avatar Nov 28 '24 18:11 telegraf-tiger[bot]