feat(inputs.procstat): Add child level tag
Summary
Add tag for children process to be able to have information by level
Checklist
- [x] No AI generated code was used in this PR
Related issues
resolves #16104
Thanks for the PR! I have one code question, but also does this close issue #16104?
Yes it's the same. The issue is in the PR description.
What do you understand exactly by :
If so could you update the PR description to close the issue? Thanks!
@tguenneguez the error means that the sample.conf file does not match what is in the README.md.
You need to add the option documentation to sample.conf and then run make docs to embed that sample.conf file into the README.md. This is done to ensure that the config options documented in the README do match the ones in the example config produced by Telegraf...
@tguenneguez the error means that the
sample.conffile does not match what is in theREADME.md.You need to add the option documentation to
sample.confand then runmake docsto embed thatsample.conffile into theREADME.md. This is done to ensure that the config options documented in the README do match the ones in the example config produced by Telegraf...
Thank you very much, I don't know how you found the cause, if you can tell me I will be more independent next time ;-)
I understand my error ;-) tag_with is for procstat metric and not for procstat_lookup metrics Also, the level is not internal information for process, but additionnal information of grouping procstat_lookup...
So I thing it will be great to have possibility to generate "procstat_lookup" for different level...
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you!
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you!
It looks like @influx-telegraf-tiger-bot still doesn't count commits/pushes as activity. A feature I requested years ago..
@tguenneguez sorry for not removing the "waiting" label when first reopening it! Should stay open now...
For readability:
@srebhan ask me to remove space : https://github.com/influxdata/telegraf/pull/16105#pullrequestreview-2632603375
What must I do ?
No, he asked to revert. (Not in these exact words)
Great, now it looks only a make docs and make fmt needs to be done to fix the linter issues.
@srebhan
thanks for the update and sorry for not being clear on the intend!
No problem
I have one question and a request. The request is to also add a metric for level zero i.e. the uppermost processes returned!
I don't see where is the problem
The question is about also adding the
leveltag to the actualprocstatprocess metrics. What do you think?
It's done ? https://github.com/influxdata/telegraf/pull/16105/files#diff-cc14c88f3221cbdf2142e6f2519dfbea11c8974a3ad070ee74775ab632a996f2R401
I have one question and a request. The request is to also add a metric for level zero i.e. the uppermost processes returned!
I don't see where is the problem
I think I missed the fact that in line 183 of filter.go the level is not set. However due to the default being zero there is no issue. Sorry for the noise!
The question is about also adding the
leveltag to the actualprocstatprocess metrics. What do you think?It's done ? https://github.com/influxdata/telegraf/pull/16105/files#diff-cc14c88f3221cbdf2142e6f2519dfbea11c8974a3ad070ee74775ab632a996f2R401
What I mean is also adding the level tag to each individual process metric. Not a must, we can still do it later.
To fix the CircleCI issues, please run make fmt and commit the fixed files!
I try to run make fmt, but no file change ...
With debug I have :
[root@dv44oag00b00008 telegraf]# make fmt -d GNU Make 3.82 Built for x86_64-redhat-linux-gnu Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Reading makefiles... Reading makefile
Makefile'... Updating makefiles.... Considering target fileMakefile'. Looking for an implicit rule forMakefile'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.o'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.c'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.cc'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.C'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.cpp'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.p'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.f'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.F'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.m'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.r'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.s'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.S'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.mod'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.sh'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile,v'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteRCS/Makefile,v'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteRCS/Makefile'. Trying pattern rule with stemMakefile'. Trying implicit prerequisites.Makefile'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteSCCS/s.Makefile'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.o'. Looking for a rule with intermediate fileMakefile.o'. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.c'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.cc'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.C'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.cpp'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.p'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.f'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.F'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.m'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.r'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.s'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.S'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.mod'. Trying pattern rule with stemMakefile.o'. Trying implicit prerequisiteMakefile.o,v'. Trying pattern rule with stemMakefile.o'. Trying implicit prerequisiteRCS/Makefile.o,v'. Trying pattern rule with stemMakefile.o'. Trying implicit prerequisiteRCS/Makefile.o'. Trying pattern rule with stemMakefile.o'. Trying implicit prerequisites.Makefile.o'. Trying pattern rule with stemMakefile.o'. Trying implicit prerequisiteSCCS/s.Makefile.o'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.c'. Looking for a rule with intermediate fileMakefile.c'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.y'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.l'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.w'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.w'. Trying pattern rule with stemMakefile.c'. Trying implicit prerequisiteMakefile.c,v'. Trying pattern rule with stemMakefile.c'. Trying implicit prerequisiteRCS/Makefile.c,v'. Trying pattern rule with stemMakefile.c'. Trying implicit prerequisiteRCS/Makefile.c'. Trying pattern rule with stemMakefile.c'. Trying implicit prerequisites.Makefile.c'. Trying pattern rule with stemMakefile.c'. Trying implicit prerequisiteSCCS/s.Makefile.c'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.y'. Looking for a rule with intermediate fileMakefile.y'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.y'. Trying implicit prerequisiteMakefile.y,v'. Trying pattern rule with stemMakefile.y'. Trying implicit prerequisiteRCS/Makefile.y,v'. Trying pattern rule with stemMakefile.y'. Trying implicit prerequisiteRCS/Makefile.y'. Trying pattern rule with stemMakefile.y'. Trying implicit prerequisites.Makefile.y'. Trying pattern rule with stemMakefile.y'. Trying implicit prerequisiteSCCS/s.Makefile.y'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.l'. Looking for a rule with intermediate fileMakefile.l'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.l'. Trying implicit prerequisiteMakefile.l,v'. Trying pattern rule with stemMakefile.l'. Trying implicit prerequisiteRCS/Makefile.l,v'. Trying pattern rule with stemMakefile.l'. Trying implicit prerequisiteRCS/Makefile.l'. Trying pattern rule with stemMakefile.l'. Trying implicit prerequisites.Makefile.l'. Trying pattern rule with stemMakefile.l'. Trying implicit prerequisiteSCCS/s.Makefile.l'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.w'. Looking for a rule with intermediate fileMakefile.w'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.w'. Trying implicit prerequisiteMakefile.w,v'. Trying pattern rule with stemMakefile.w'. Trying implicit prerequisiteRCS/Makefile.w,v'. Trying pattern rule with stemMakefile.w'. Trying implicit prerequisiteRCS/Makefile.w'. Trying pattern rule with stemMakefile.w'. Trying implicit prerequisites.Makefile.w'. Trying pattern rule with stemMakefile.w'. Trying implicit prerequisiteSCCS/s.Makefile.w'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.w'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.cc'. Looking for a rule with intermediate fileMakefile.cc'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.cc'. Trying implicit prerequisiteMakefile.cc,v'. Trying pattern rule with stemMakefile.cc'. Trying implicit prerequisiteRCS/Makefile.cc,v'. Trying pattern rule with stemMakefile.cc'. Trying implicit prerequisiteRCS/Makefile.cc'. Trying pattern rule with stemMakefile.cc'. Trying implicit prerequisites.Makefile.cc'. Trying pattern rule with stemMakefile.cc'. Trying implicit prerequisiteSCCS/s.Makefile.cc'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.C'. Looking for a rule with intermediate fileMakefile.C'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.C'. Trying implicit prerequisiteMakefile.C,v'. Trying pattern rule with stemMakefile.C'. Trying implicit prerequisiteRCS/Makefile.C,v'. Trying pattern rule with stemMakefile.C'. Trying implicit prerequisiteRCS/Makefile.C'. Trying pattern rule with stemMakefile.C'. Trying implicit prerequisites.Makefile.C'. Trying pattern rule with stemMakefile.C'. Trying implicit prerequisiteSCCS/s.Makefile.C'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.cpp'. Looking for a rule with intermediate fileMakefile.cpp'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.cpp'. Trying implicit prerequisiteMakefile.cpp,v'. Trying pattern rule with stemMakefile.cpp'. Trying implicit prerequisiteRCS/Makefile.cpp,v'. Trying pattern rule with stemMakefile.cpp'. Trying implicit prerequisiteRCS/Makefile.cpp'. Trying pattern rule with stemMakefile.cpp'. Trying implicit prerequisites.Makefile.cpp'. Trying pattern rule with stemMakefile.cpp'. Trying implicit prerequisiteSCCS/s.Makefile.cpp'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.p'. Looking for a rule with intermediate fileMakefile.p'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.web'. Trying pattern rule with stemMakefile.p'. Trying implicit prerequisiteMakefile.p,v'. Trying pattern rule with stemMakefile.p'. Trying implicit prerequisiteRCS/Makefile.p,v'. Trying pattern rule with stemMakefile.p'. Trying implicit prerequisiteRCS/Makefile.p'. Trying pattern rule with stemMakefile.p'. Trying implicit prerequisites.Makefile.p'. Trying pattern rule with stemMakefile.p'. Trying implicit prerequisiteSCCS/s.Makefile.p'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.web'. Looking for a rule with intermediate fileMakefile.web'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.web'. Trying implicit prerequisiteMakefile.web,v'. Trying pattern rule with stemMakefile.web'. Trying implicit prerequisiteRCS/Makefile.web,v'. Trying pattern rule with stemMakefile.web'. Trying implicit prerequisiteRCS/Makefile.web'. Trying pattern rule with stemMakefile.web'. Trying implicit prerequisites.Makefile.web'. Trying pattern rule with stemMakefile.web'. Trying implicit prerequisiteSCCS/s.Makefile.web'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.f'. Looking for a rule with intermediate fileMakefile.f'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.F'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.r'. Trying pattern rule with stemMakefile.f'. Trying implicit prerequisiteMakefile.f,v'. Trying pattern rule with stemMakefile.f'. Trying implicit prerequisiteRCS/Makefile.f,v'. Trying pattern rule with stemMakefile.f'. Trying implicit prerequisiteRCS/Makefile.f'. Trying pattern rule with stemMakefile.f'. Trying implicit prerequisites.Makefile.f'. Trying pattern rule with stemMakefile.f'. Trying implicit prerequisiteSCCS/s.Makefile.f'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.F'. Looking for a rule with intermediate fileMakefile.F'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.F'. Trying implicit prerequisiteMakefile.F,v'. Trying pattern rule with stemMakefile.F'. Trying implicit prerequisiteRCS/Makefile.F,v'. Trying pattern rule with stemMakefile.F'. Trying implicit prerequisiteRCS/Makefile.F'. Trying pattern rule with stemMakefile.F'. Trying implicit prerequisites.Makefile.F'. Trying pattern rule with stemMakefile.F'. Trying implicit prerequisiteSCCS/s.Makefile.F'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.r'. Looking for a rule with intermediate fileMakefile.r'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.l'. Trying pattern rule with stemMakefile.r'. Trying implicit prerequisiteMakefile.r,v'. Trying pattern rule with stemMakefile.r'. Trying implicit prerequisiteRCS/Makefile.r,v'. Trying pattern rule with stemMakefile.r'. Trying implicit prerequisiteRCS/Makefile.r'. Trying pattern rule with stemMakefile.r'. Trying implicit prerequisites.Makefile.r'. Trying pattern rule with stemMakefile.r'. Trying implicit prerequisiteSCCS/s.Makefile.r'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.F'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.m'. Looking for a rule with intermediate fileMakefile.m'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.ym'. Trying pattern rule with stemMakefile.m'. Trying implicit prerequisiteMakefile.m,v'. Trying pattern rule with stemMakefile.m'. Trying implicit prerequisiteRCS/Makefile.m,v'. Trying pattern rule with stemMakefile.m'. Trying implicit prerequisiteRCS/Makefile.m'. Trying pattern rule with stemMakefile.m'. Trying implicit prerequisites.Makefile.m'. Trying pattern rule with stemMakefile.m'. Trying implicit prerequisiteSCCS/s.Makefile.m'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.ym'. Looking for a rule with intermediate fileMakefile.ym'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.ym'. Trying implicit prerequisiteMakefile.ym,v'. Trying pattern rule with stemMakefile.ym'. Trying implicit prerequisiteRCS/Makefile.ym,v'. Trying pattern rule with stemMakefile.ym'. Trying implicit prerequisiteRCS/Makefile.ym'. Trying pattern rule with stemMakefile.ym'. Trying implicit prerequisites.Makefile.ym'. Trying pattern rule with stemMakefile.ym'. Trying implicit prerequisiteSCCS/s.Makefile.ym'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.r'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.s'. Looking for a rule with intermediate fileMakefile.s'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.S'. Trying pattern rule with stemMakefile.s'. Trying implicit prerequisiteMakefile.s,v'. Trying pattern rule with stemMakefile.s'. Trying implicit prerequisiteRCS/Makefile.s,v'. Trying pattern rule with stemMakefile.s'. Trying implicit prerequisiteRCS/Makefile.s'. Trying pattern rule with stemMakefile.s'. Trying implicit prerequisites.Makefile.s'. Trying pattern rule with stemMakefile.s'. Trying implicit prerequisiteSCCS/s.Makefile.s'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.S'. Looking for a rule with intermediate fileMakefile.S'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.S'. Trying implicit prerequisiteMakefile.S,v'. Trying pattern rule with stemMakefile.S'. Trying implicit prerequisiteRCS/Makefile.S,v'. Trying pattern rule with stemMakefile.S'. Trying implicit prerequisiteRCS/Makefile.S'. Trying pattern rule with stemMakefile.S'. Trying implicit prerequisites.Makefile.S'. Trying pattern rule with stemMakefile.S'. Trying implicit prerequisiteSCCS/s.Makefile.S'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.S'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.mod'. Looking for a rule with intermediate fileMakefile.mod'. Avoiding implicit rule recursion. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.mod'. Trying implicit prerequisiteMakefile.mod,v'. Trying pattern rule with stemMakefile.mod'. Trying implicit prerequisiteRCS/Makefile.mod,v'. Trying pattern rule with stemMakefile.mod'. Trying implicit prerequisiteRCS/Makefile.mod'. Trying pattern rule with stemMakefile.mod'. Trying implicit prerequisites.Makefile.mod'. Trying pattern rule with stemMakefile.mod'. Trying implicit prerequisiteSCCS/s.Makefile.mod'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.c'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.cc'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.C'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.cpp'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.p'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.f'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.F'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.m'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.r'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.s'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.S'. Trying pattern rule with stemMakefile'. Rejecting impossible implicit prerequisiteMakefile.mod'. Trying pattern rule with stemMakefile'. Trying implicit prerequisiteMakefile.sh'. Looking for a rule with intermediate fileMakefile.sh'. Avoiding implicit rule recursion. Trying pattern rule with stemMakefile.sh'. Trying implicit prerequisiteMakefile.sh,v'. Trying pattern rule with stemMakefile.sh'. Trying implicit prerequisiteRCS/Makefile.sh,v'. Trying pattern rule with stemMakefile.sh'. Trying implicit prerequisiteRCS/Makefile.sh'. Trying pattern rule with stemMakefile.sh'. Trying implicit prerequisites.Makefile.sh'. Trying pattern rule with stemMakefile.sh'. Trying implicit prerequisiteSCCS/s.Makefile.sh'. No implicit rule found forMakefile'. Finished prerequisites of target fileMakefile'. No need to remake targetMakefile'. Updating goal targets.... Considering target filefmt'. Filefmt' does not exist. Finished prerequisites of target filefmt'. Must remake targetfmt'. Invoking recipe from Makefile:158 to update targetfmt'. Putting child 0x1eccee0 (fmt) PID 39646 on the chain. Live child 0x1eccee0 (fmt) PID 39646 Reaping winning child 0x1eccee0 PID 39646 Removing child 0x1eccee0 PID 39646 from chain. Successfully remade target file `fmt'.
@tguenneguez do you run golang v1.24? I pushed the format corrections for you...
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.
:partying_face: This pull request decreases the Telegraf binary size by -1.08 % for linux amd64 (new size: 288.7 MB, nightly size 291.8 MB)
:package: Click here to get additional PR build artifacts
Artifact URLs
@DStrand1 I will assign this back to you for giving it a final check as the code changed quite a bit...