telegraf icon indicating copy to clipboard operation
telegraf copied to clipboard

feat(inputs.cisco_telemetry_mdt): Include delete field

Open severindellsperger opened this issue 2 years ago • 1 comments

Required for all PRs

  • [x] Updated associated README.md.
  • [x] Wrote appropriate unit tests.
  • [x] Pull request title or commits are in conventional commit format

resolves #12286

Implement the logic to include the delete field as discussed in #12286 to support Event-Driven Telemetry (EDT).

severindellsperger avatar Dec 06 '22 16:12 severindellsperger

@severindellsperger, did you ask Cisco to host the repo publicly? Have they acknowledged the request?

powersj avatar Jan 10 '23 14:01 powersj

@severindellsperger, did you ask Cisco to host the repo publicly? Have they acknowledged the request? I have no answer yet. I have a meeting next week and will discuss it then.

severindellsperger avatar Jan 11 '23 14:01 severindellsperger

The PR is out: https://github.com/cisco-ie/nx-telemetry-proto/pull/2 Let's hope it will be merged soon so that we can adjust.

severindellsperger avatar Jan 17 '23 14:01 severindellsperger

The PR is out: cisco-ie/nx-telemetry-proto#2 Let's hope it will be merged soon so that we can adjust.

Looks like that got landed. Thank you for doing that work!

powersj avatar Jan 17 '23 18:01 powersj

@powersj @srebhan I made the necessary changes. I think the PR is now ready for the final review.

severindellsperger avatar Jan 18 '23 10:01 severindellsperger

Oh and you should run make docs...

srebhan avatar Jan 18 '23 17:01 srebhan