telegraf icon indicating copy to clipboard operation
telegraf copied to clipboard

build: github Workflows security hardening

Open sashashura opened this issue 2 years ago • 1 comments

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

sashashura avatar Sep 20 '22 14:09 sashashura

They are triggered on pull_request which already has limited permissions, but you want for consistency I can add!

sashashura avatar Sep 20 '22 19:09 sashashura

Just for the reference these are permissions golangci-lint runs with on push: image

sashashura avatar Sep 23 '22 18:09 sashashura