telegraf icon indicating copy to clipboard operation
telegraf copied to clipboard
verified publisher icon influxdata

chore(deps): Replace go-ping by pro-bing

Open Hipska opened this issue 3 years ago • 5 comments

Required for all PRs

  • [x] Updated associated README.md.
  • [x] Wrote appropriate unit tests.
  • [x] Pull request title or commits are in conventional commit format

The go-ping/ping package is going to be abandoned.

Hipska avatar Sep 19 '22 14:09 Hipska

Yea, we're planning to expand it to support other probe types. Like TCP or HTTP. We decided to go with a silly name. :grin:

SuperQ avatar Sep 20 '22 08:09 SuperQ

There is no notice on go-ping/ping that says it's abandoned. I see that prometheus-community/pro-bing has recent activity and I appreciate the work people are doing there. Can you share some background on why we should switch to the fork?

reimda avatar Sep 21 '22 19:09 reimda

In their Slack Channel @SuperQ opted to archive it or at least mention it on the readme, but none of the maintainers responded to that. It is so abandoned that they even not care to inform the users 😉

Hipska avatar Sep 21 '22 19:09 Hipska

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.

:relaxed: This pull request doesn't significantly change the Telegraf binary size (less than 1%)

:package: Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

telegraf-tiger[bot] avatar Sep 21 '22 19:09 telegraf-tiger[bot]

Yea, that's how difficult it is. Due to the dual approval necessary, I can't open a PR to even say that it's abandoned.

If either of you could open a PR to update the README, I could try and get it merged eventually.

SuperQ avatar Sep 21 '22 20:09 SuperQ

And thanks @SuperQ for keeping the ping project alive with pro-bing

reimda avatar Sep 27 '22 20:09 reimda

@SuperQ do you have something in mind?

If either of you could open a PR to update the README, I could try and get it merged eventually.

Hipska avatar Dec 23 '22 11:12 Hipska