telegraf icon indicating copy to clipboard operation
telegraf copied to clipboard

feat(inputs.riak): Add missing Riak metrics

Open efcasado opened this issue 3 years ago • 3 comments

Required for all PRs

  • [ ] Updated associated README.md.
  • [ ] Wrote appropriate unit tests.
  • [ ] Pull request title or commits are in conventional commit format

resolves #11803

This PR adds support for 400+ new Riak metrics. Mostly, as a result of adding support for the latest Riak version (ie. 3.0.10).

efcasado avatar Sep 14 '22 09:09 efcasado

Thanks so much for the pull request! :handshake: :black_nib: Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

telegraf-tiger[bot] avatar Sep 14 '22 09:09 telegraf-tiger[bot]

!signed-cla

efcasado avatar Sep 14 '22 13:09 efcasado

Whoa these are indeed a lot of new fields. I'm just wondering if it still makes sense to all put them inside 1 metric. Maybe a more logical grouping like riak_<name> would be useful?

Hipska avatar Sep 23 '22 08:09 Hipska

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you!

telegraf-tiger[bot] avatar Oct 27 '22 18:10 telegraf-tiger[bot]