telegraf icon indicating copy to clipboard operation
telegraf copied to clipboard

feat(inputs.opcua): add use regular reads workaround

Open R290 opened this issue 2 years ago • 3 comments

Required for all PRs

  • [x] Updated associated README.md.
  • [x] Wrote appropriate unit tests.
  • [x] Pull request title or commits are in conventional commit format

resolves #11559

Added workaround to use regular reads instead of registered reads.

R290 avatar Aug 07 '22 10:08 R290

Have also a look at the test-go-linux check and fix the issues that come from it. You can also run this on your local machine before pushing, see Unit Tests section.

Hipska avatar Sep 14 '22 07:09 Hipska

Good point on the make docs. I accepted your changes from within GitHub, so I didn't run any checks before committing. For some reason make check wants me to change 375 files (including opcua.go) using make fmt...

R290 avatar Sep 14 '22 17:09 R290

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.

:partying_face: This pull request decreases the Telegraf binary size by -2.72 % for linux amd64 (new size: 148.5 MB, nightly size 152.6 MB)

:package: Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

telegraf-tiger[bot] avatar Sep 14 '22 17:09 telegraf-tiger[bot]

@R290 is this one ready to review or was there additional development required? Thanks!

powersj avatar Sep 21 '22 22:09 powersj

The attached issue contains of 2 parts, and this pull only resolves the second part: telegraf needs to handle auto-reconnect and that we should reconsider using registered reads For the first part some issues within the underlying opcua library need to be fixed, but this has been eerily quiet for the past six weeks or so. Feel free to review and merge though, the changes are only a small workaround.

R290 avatar Sep 26 '22 16:09 R290

I know this has already been merged, but it has not yet been released. Might I suggest using use_unregistered_reads as the config name. I think regular could be confusing.

LarsStegman avatar Sep 27 '22 15:09 LarsStegman

@LarsStegman that's a great idea! Are you willing to put up a pr or should i?

MyaLongmire avatar Sep 27 '22 15:09 MyaLongmire

You can do it if you want 🙂

LarsStegman avatar Sep 27 '22 15:09 LarsStegman

@LarsStegman pr can be found here :)

MyaLongmire avatar Sep 27 '22 16:09 MyaLongmire