telegraf
telegraf copied to clipboard
feat(inputs.opcua): add use regular reads workaround
Required for all PRs
- [x] Updated associated README.md.
- [x] Wrote appropriate unit tests.
- [x] Pull request title or commits are in conventional commit format
resolves #11559
Added workaround to use regular reads instead of registered reads.
Have also a look at the test-go-linux
check and fix the issues that come from it.
You can also run this on your local machine before pushing, see Unit Tests section.
Good point on the make docs
. I accepted your changes from within GitHub, so I didn't run any checks before committing. For some reason make check
wants me to change 375 files (including opcua.go) using make fmt
...
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.
:partying_face: This pull request decreases the Telegraf binary size by -2.72 % for linux amd64 (new size: 148.5 MB, nightly size 152.6 MB)
:package: Click here to get additional PR build artifacts
Artifact URLs
@R290 is this one ready to review or was there additional development required? Thanks!
The attached issue contains of 2 parts, and this pull only resolves the second part:
telegraf needs to handle auto-reconnect and that we should reconsider using registered reads
For the first part some issues within the underlying opcua library need to be fixed, but this has been eerily quiet for the past six weeks or so. Feel free to review and merge though, the changes are only a small workaround.
I know this has already been merged, but it has not yet been released. Might I suggest using use_unregistered_reads
as the config name. I think regular
could be confusing.
@LarsStegman that's a great idea! Are you willing to put up a pr or should i?
You can do it if you want 🙂
@LarsStegman pr can be found here :)