telegraf icon indicating copy to clipboard operation
telegraf copied to clipboard

feat: support ingesting multi-measures to timestream

Open lohithshetty opened this issue 3 years ago • 7 comments

Fixes: #10493

Required for all PRs:

  • [x] Updated associated README.md.
  • [x] Wrote appropriate unit tests.
  • [x] Pull request title or commits are in conventional commit format

Feature: support ingesting multi-measures to timestream

The feature controlled using the use_multi_measure_records field which is set to false by default for backward compatibility.

lohithshetty avatar Jun 24 '22 02:06 lohithshetty

Hi Lohith, thanks for the PR. Could you update the sample config to include the new settings? https://github.com/influxdata/telegraf/blob/master/docs/developers/SAMPLE_CONFIG.md#style

Also update readme.md to describe how the settings are useful and maybe link to timestream documentation?

reimda avatar Jun 24 '22 17:06 reimda

Hey @lohithshetty, how does this code relate to the other two PRs (#11094 and #10952) with the exactly same PR title? Can we close those?

srebhan avatar Jul 08 '22 13:07 srebhan

Hi reimda@, apologies for the delayed response. I've updated readme.md to include details about multi-measure feature. Thank you.

lohithshetty avatar Jul 13 '22 18:07 lohithshetty

Hi @srebhan the other two PRs (https://github.com/influxdata/telegraf/pull/11094 and https://github.com/influxdata/telegraf/pull/10952) can be closed as this PR covers the same change. Thank you.

lohithshetty avatar Jul 13 '22 18:07 lohithshetty

@lohithshetty I think you did not push the changes yet, did you? Let me know once you are ready for another review round...

srebhan avatar Jul 21 '22 08:07 srebhan

@srebhan I pushed the changes, can you please take a look. Thank you.

lohithshetty avatar Jul 22 '22 22:07 lohithshetty

Hey @lohithshetty thanks for the push. This leaves us with the question on why lines 123 - 126 are different in structure... Can you please comment on this?!

srebhan avatar Jul 26 '22 15:07 srebhan

Hi @srebhan, would appreciate your help in reviewing and closing this PR. Thank you.

lohithshetty avatar Aug 11 '22 16:08 lohithshetty

@lohithshetty beside my comment, can you please run make docs and push the changes to fix the unit tests!?

srebhan avatar Aug 16 '22 09:08 srebhan

Hi @srebhan, Thanks for reviewing the pull request, I've made the changes as per your suggestion. Currently circle-ci failing for mac for plugin plugins/outputs/graylog ( not related to this pull request ). Appreciate merging this changes. Thank you.

lohithshetty avatar Aug 24 '22 22:08 lohithshetty

@srebhan Are we good to merge this change this week?

kingston88 avatar Sep 08 '22 16:09 kingston88

@reimda @srebhan Can we merge this change?

kingston88 avatar Sep 09 '22 15:09 kingston88

@reimda @srebhan Can we merge this change?

We merge after two review approvals, so it's close. It looks like there is one outstanding item from srebhan's review that needs to be taken care of. Just adding some comments?

reimda avatar Sep 09 '22 16:09 reimda

@reimda @srebhan
README has a section which explains different modes with examples ( refer to Mapping data from Influx to Timestream section in README). Please let me know if you think more explanation/comments are required.

lohithshetty avatar Sep 13 '22 17:09 lohithshetty

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.

:partying_face: This pull request decreases the Telegraf binary size by -1.60 % for linux amd64 (new size: 150.2 MB, nightly size 152.6 MB)

:package: Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

telegraf-tiger[bot] avatar Sep 16 '22 21:09 telegraf-tiger[bot]

Is this released? tested with this tag telegraf:1.24.3 and seems like its not.

hadiel05 avatar Nov 03 '22 18:11 hadiel05

Anything tagged a new "feature" is released in the next minor version. This should go out in v1.25.0

powersj avatar Nov 03 '22 18:11 powersj