feat: support ingesting multi-measures to timestream
Fixes: #10493
Required for all PRs:
- [x] Updated associated README.md.
- [x] Wrote appropriate unit tests.
- [x] Pull request title or commits are in conventional commit format
Feature: support ingesting multi-measures to timestream
The feature controlled using the use_multi_measure_records field which is set to false by default for backward compatibility.
Hi Lohith, thanks for the PR. Could you update the sample config to include the new settings? https://github.com/influxdata/telegraf/blob/master/docs/developers/SAMPLE_CONFIG.md#style
Also update readme.md to describe how the settings are useful and maybe link to timestream documentation?
Hey @lohithshetty, how does this code relate to the other two PRs (#11094 and #10952) with the exactly same PR title? Can we close those?
Hi reimda@, apologies for the delayed response. I've updated readme.md to include details about multi-measure feature. Thank you.
Hi @srebhan the other two PRs (https://github.com/influxdata/telegraf/pull/11094 and https://github.com/influxdata/telegraf/pull/10952) can be closed as this PR covers the same change. Thank you.
@lohithshetty I think you did not push the changes yet, did you? Let me know once you are ready for another review round...
@srebhan I pushed the changes, can you please take a look. Thank you.
Hey @lohithshetty thanks for the push. This leaves us with the question on why lines 123 - 126 are different in structure... Can you please comment on this?!
Hi @srebhan, would appreciate your help in reviewing and closing this PR. Thank you.
@lohithshetty beside my comment, can you please run make docs and push the changes to fix the unit tests!?
Hi @srebhan, Thanks for reviewing the pull request, I've made the changes as per your suggestion. Currently circle-ci failing for mac for plugin plugins/outputs/graylog ( not related to this pull request ). Appreciate merging this changes. Thank you.
@srebhan Are we good to merge this change this week?
@reimda @srebhan Can we merge this change?
@reimda @srebhan Can we merge this change?
We merge after two review approvals, so it's close. It looks like there is one outstanding item from srebhan's review that needs to be taken care of. Just adding some comments?
@reimda @srebhan
README has a section which explains different modes with examples ( refer to Mapping data from Influx to Timestream section in README). Please let me know if you think more explanation/comments are required.
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.
:partying_face: This pull request decreases the Telegraf binary size by -1.60 % for linux amd64 (new size: 150.2 MB, nightly size 152.6 MB)
:package: Click here to get additional PR build artifacts
Artifact URLs
Is this released? tested with this tag telegraf:1.24.3 and seems like its not.
Anything tagged a new "feature" is released in the next minor version. This should go out in v1.25.0