telegraf
telegraf copied to clipboard
influxdata
feat(inputs.win_perf_counters): Add remote computers support
Replacing: https://github.com/influxdata/telegraf/pull/6590 Resolves https://github.com/influxdata/telegraf/issues/1899
At the moment we are waiting for customer/community participation to help ensure this change meets their needs (configuration makes sense, etc.). Therefore we will need to be able to re-base it and get new build artifacts on request, moving this pull request to be under a local branch seems like the best approach.
original description:
Added support for reading performance counters from remote computers. User, under who is Telegraf running, must be already authenticated to the remote computer(s).
The support is added via additional optional global parameter Sources. This parameter can be also set for performance object to configure per host-specific performance counter:
[[inputs.win_perf_counters]]
PreVistaSupport=false
UseWildcardsExpansion=false
UsePerfCounterTime=true
CountersRefreshInterval="0"
PrintValid=true
# Names or ip addresses of remote computers to gather counters from, including local computer.
# Telegraf's user must be already authenticated to the remote computers.
# It can be overridden at the object level
Sources=["localhost", "192.168.10.12"]
[[inputs.win_perf_counters.object]]
# Overrides the Sources global parameter for current performance object.
Sources = ["192.168.1.68"]
# Processor usage, alternative to native, reports on a per core.
ObjectName = "Processor"
Instances = ["*"]
Counters = [
"% Processor Time",
]
Measurement = "win_cpu"
It allows to define the same configuration for multiple computers and also different configurations per computer.
Computer name is then added as the source tag. Telegraf host compuper has the source set to the computer name.
Readme has been also enhanced with plugins's schema description.
Required for all PRs:
- [X] Signed CLA.
- [X] Associated README.md updated.
- [X] Has appropriate unit tests.
@cruscio I think you and Allscripts have been interested in this feature for some time now (https://github.com/influxdata/telegraf/issues/8238). Would you be able to test the build artifacts of this PR posted by telegraf-tiger? Once this PR passes code review we would like to merge it but only if it meets users' needs, including yours. Thanks!
Closing due to lack of interest, if you are interested in this feature please leave a comment.
@deweter I can re-open this and get it ready for review, would you be able to help test this feature and provide feedback on the config to help make sure it is ready?
Yes, we would. At this moment, we are using telegraf in env with 500+ servers. Now it has to be deployed locally just because perfmon counters cannot be gathered remotely.
@deweter Whenever you have time, could you try the artifacts posted by the tiger bot and see if these new feature works for you? And let me know if the documentation is enough: https://github.com/influxdata/telegraf/blob/vh-wpc-remote-computers-support/plugins/inputs/win_perf_counters/README.md
Thank you!
@deweter Have you had time to test out this feature? The artifacts will expire in the next 8 days.
I am sorry for the delay. Please, bare with me, I am going to have a look at it within next two weeks.
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.
:thumbsup: This pull request doesn't change the Telegraf binary size
:package: Click here to get additional PR build artifacts
Artifact URLs
![telegraf-tiger[bot] avatar](https://avatars.githubusercontent.com/in/94907?v=4 "Published by a pub.dev verified publisher"){kind=small}
No worries, I've re-based so now the artifacts posted will last another month.
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you!
Hello, can this PR be reopened? I am interested in this feature. I can provide support needed to get this merged. Thank you!
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.
:thumbsup: This pull request doesn't change the Telegraf binary size
:package: Click here to get additional PR build artifacts
Artifact URLs
@hpainter2002 thank you, your help would be appreciated, can you try out one of the artifacts the Tiger bot posted to see if this feature works for you? If you could also provide feedback on the documentation in this PR that would be great.
@sspaink Yes, I can try out the artifact. I will let you know if the feature is sufficient.
@sspaink I have tested windows_amd64.zip. Seems to work for us. I have also added a few suggestions on the documentation (Let me know if you would prefer me to start a review). Feel free to update as you see fit. Thank you!
Thanks so much for the pull request!
:handshake: :black_nib: Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. Downloads for additional architectures and packages are available below.
:relaxed: This pull request doesn't significantly change the Telegraf binary size (less than 1%)
