influxdb icon indicating copy to clipboard operation
influxdb copied to clipboard

feat(notification/teams): add teams notification - server side

Open sranka opened this issue 4 years ago • 1 comments

This PR adds support for Microsoft Teams in InfluxDB notification endpoints and notification rules to the server-side of InfluxDB. It contains code changes that were reviewed in #18916 (which also contained UI part, which is not subject of this PR)

What is in this PR:

  • implementation and tests of teams endpoint and rule
  • swagger updated with teams notification rule and endpoint
  • [ ] CHANGELOG.md updated with a link to the PR (not the Issue)
  • [x] Well-formatted commit messages
  • [ ] Rebased/mergeable
  • [x] Tests pass
  • [ ] http/swagger.yml updated (if modified Go structs or API)
  • [ ] Feature flagged (if modified API)
  • [ ] Documentation updated or issue created (provide link to issue/pr)
  • [x] Signed CLA (if not already signed)

sranka avatar Oct 14 '20 13:10 sranka

If I include swagger update in this PR, UI-dependant automated tests fail (ci/circleci: jlint, jstest, build fail). The root cause is that the UI code cannot be built against types that are generated from an updated swagger file. I could possibly update UI types (as I originally did #18916), but this is AFAIK in a different repo (influxdata/ui). Any advice on how to proceed with this tension between ui and influxdb repositories?

https://github.com/influxdata/influxdb/pull/18916/commits/52f99f3a2aca1464f8fca96d0cd0df011fa2ab70 is the swagger change, it is only additive.

sranka avatar Oct 14 '20 14:10 sranka