influxdb-java
influxdb-java copied to clipboard
Fixes issue: InfluxDBResultMapper doesnt call POJO setter
Closes #670
Things included in this PR:
- Call field setters instead of setting field values directly.
- This PR maintains existing behaviour ie setting fields directly ignoring setters.
- Priority is given to field setter if one exists. If not, field is set directly.
@fmachado Im not sure if I need to run format sh. But when I do, I get a lot of diffs in most Java files. Anything I need to do with formattting?
@sjoshid thanks for submitting this PR.
Im not sure if I need to run format sh.
I don't remember when was the last time that I had to run that shell script as I'm using the checkstyle.xml for a while.
But before getting into the formatting issues, could you please check why Travis build failed?
https://travis-ci.org/github/influxdata/influxdb-java/builds/685113586
Codecov Report
Merging #676 into master will decrease coverage by
0.06%
. The diff coverage is88.17%
.
@@ Coverage Diff @@
## master #676 +/- ##
============================================
- Coverage 88.18% 88.11% -0.07%
- Complexity 722 737 +15
============================================
Files 69 69
Lines 2513 2566 +53
Branches 268 285 +17
============================================
+ Hits 2216 2261 +45
- Misses 208 210 +2
- Partials 89 95 +6
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...n/java/org/influxdb/impl/InfluxDBResultMapper.java | 87.75% <88.17%> (-1.06%) |
72.00 <28.00> (+15.00) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ad5d6a8...5c9bd27. Read the comment docs.
@fmachado Any feedback on this one?
@majst01 I have been waiting for @fmachado for feedback but havent received it. Can you provide one?
whats the status on this? this would be a super useful feature to have