influxdb-client-java icon indicating copy to clipboard operation
influxdb-client-java copied to clipboard

chore: delete unnecessary inheritance of FlowableBufferTimedFlushable

Open OrezzerO opened this issue 1 year ago • 4 comments

Closes #

Proposed Changes

FlowableBufferTimedFlushable doesn't need to inherit from FlowableTransformer. Therefore, delete this inheritance relationship to reduce the complexity of the code. The original implementation was quite confusing.

Checklist

  • [x] CHANGELOG.md updated
  • [x] Rebased/mergeable
  • [x] A test has been added if appropriate
  • [x] mvn test completes successfully
  • [x] Commit messages are conventional
  • [x] Sign CLA (if not already signed)

OrezzerO avatar Dec 25 '24 10:12 OrezzerO

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.51%. Comparing base (f9283d6) to head (50589b1). Report is 9 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #794      +/-   ##
============================================
+ Coverage     88.50%   88.51%   +0.01%     
+ Complexity      787      785       -2     
============================================
  Files           174      174              
  Lines          7203     7202       -1     
  Branches        405      405              
============================================
  Hits           6375     6375              
+ Misses          697      696       -1     
  Partials        131      131              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 25 '24 10:12 codecov-commenter

Which part of CHANGELOG.md should I record this PR ?

OrezzerO avatar Dec 25 '24 13:12 OrezzerO

@OrezzerO, please add a new section titled “Features” to the 7.3.0 release notes. Thank you! 😊

bednar avatar Jan 06 '25 08:01 bednar

@bednar CHANGELOG.md updated.

OrezzerO avatar Jan 09 '25 05:01 OrezzerO