helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Make sidecar default resources configurable

Open korjek opened this issue 3 years ago • 4 comments

When default sidecar resources don't fit someone's need it's preferable to specify a custom default value instead of adding annotations to every pod that runs sidecar. So this PR exposes variables to configure default sidecar resources.

This was tested by specifying custom values for default resources and deploying to k8s. kubectl describe pod showed that telegraf sidecar has resources specified using values.yaml

korjek avatar Sep 19 '22 09:09 korjek

@jaymebrd sorry for bothering you, but not sure who should be tagged. Could you please advice who can helm with pushing this PR forward?

korjek avatar Sep 23 '22 12:09 korjek

@powersj @sspaink guys, probably you can take a look or assign the right person, please

korjek avatar Oct 06 '22 05:10 korjek

@wojciechka could you please take a look?

korjek avatar Oct 13 '22 12:10 korjek

@wojciechka could you please take a look?

Hi @korjek, I apologize, this got lost in my notifications.

Can you update the chart version as we've released telegraf-operator and chart in the meantime? It should then be possible to run and merge it.

This will cause a tiny issue, because we're trying to align telegraf-operator and helm chart version for automation purposes, but we'll work it out.

wojciechka avatar Oct 13 '22 14:10 wojciechka

@wojciechka sorry, I completely lost track of this PR. Updated.

korjek avatar Jan 25 '23 08:01 korjek

@wojciechka could we proceed with this PR, please?

korjek avatar Jan 31 '23 08:01 korjek

@jeffreyssmith2nd @srebhan could anyone take a look, please?

korjek avatar Feb 09 '23 06:02 korjek