influxdata
[influxdb] Add loadBalancerSourceRanges support, refactor config map
Add support for service.spec.loadBalancerSourceRanges. We can control security group entries for AWS load balancers. Chart supported this in previous versions (3.x).
Add a helper to format config maps sections without breaking current functionality.
- [ ] CHANGELOG.md updated
- [x] Rebased/mergable
- [x] Tests pass
- [x] Sign CLA (if not already signed)
Happy to accept the load balancer changes, but not the config map break.
Please feel free to clean this up and tag me
Happy to accept the load balancer changes, but not the config map break.
Looks like a nice factoring out with one logical changes which is to | int64 numeric values to avoid having them converted to scientific notation apparently. Is that breaking?
Happy to accept the load balancer changes, but not the config map break.
Looks like a nice factoring out with one logical changes which is to
| int64numeric values to avoid having them converted to scientific notation apparently. Is that breaking?
Yes, as it assumes that values can only be strong, bool, or int. There’s no clause for arrays or floats.
TOML wrangling is a mess in Helm and I’d rather discourage using yaml to generate it. Of course, if you wish to add some Rego to confirm it works with a varied and complete configuration, then by all means do.
I’ve added a basic test case to build into CI in an unrelated PR
https://github.com/influxdata/helm-charts/pull/281/files
...
Yes, as it assumes that values can only be strong, bool, or int. There’s no clause for arrays or floats.
TOML wrangling is a mess in Helm and I’d rather discourage using yaml to generate it. Of course, if you wish to add some Rego to confirm it works with a varied and complete configuration, then by all means do.
I’ve added a basic test case to build into CI in an unrelated PR
https://github.com/influxdata/helm-charts/pull/281/files
@rawkode I have found a case for arrays access-log-status-filters = [] (doc), but I do not see any values that can be floats. Do I miss something?
@rawkode @naseemkullah I have dropped 'int64' shenanigans, but left the helper, I can drop it too if you want. I have also rebased the code with master.