giraffe icon indicating copy to clipboard operation
giraffe copied to clipboard

Published 20 hours ago • verified publisher icon influxdata

feat: gauge mini

Open Sciator opened this issue 4 years ago • 9 comments

ui#366

Minigauge & Bullet graph

image

Created and developing in Sciator/giraffe-components-concepts runable sandbox.

TODO:

  • [x] All TODOs from Sciator/giraffe-components-concepts
  • [x] Show multiple values
  • [x] Add missing knobs into storybook
  • [x] Swagger
  • [x] Simpler types
  • [x] Giraffe style formaters
  • [x] UI options
  • [x] Feature flag
  • [x] Fix autosizer
  • [x] Docs

Sciator avatar Nov 17 '20 11:11 Sciator

Context, contributes to: https://github.com/influxdata/giraffe/issues/198

ivankudibal avatar Nov 20 '20 13:11 ivankudibal

Put "WIP" in the title and also unassigning myself and @alexpaxton for now.

TCL735 avatar Dec 18 '20 22:12 TCL735

@ivankudibal @Sciator the status of this Pull Request is still "draft". Can you please update the status so that it is not "draft"?

TCL735 avatar Jan 15 '21 21:01 TCL735

Please remove draft status before re-assigning me to this review. I am still interested in reviewing it, but not while it has the "draft" status.

TCL735 avatar Jan 19 '21 20:01 TCL735

@ivankudibal @Sciator - are there product requirements for this feature? I am aware that this is an issue written for Giraffe. However, a repo's issue should either come from a product team's requirements or have some reference to them.

While this looks cool, I would like to review this more objectively by comparing to product requirements.

TCL735 avatar Jan 22 '21 19:01 TCL735

https://github.com/influxdata/giraffe/issues/198 items 5 and 6

ivankudibal avatar Jan 22 '21 20:01 ivankudibal

@ivankudibal What I meant was an actual list of product requirements that is outside of any issues in github. I am trying to see where the demand for this feature came from, other than a github issue. As I said, I understand there are issues listed in github with all kinds of different requests. InfluxData has internal discussions regarding what should be developed. I am looking for some sort of insight into that internal discussion. Because so far, I have been unable to find any.

TCL735 avatar Jan 24 '21 23:01 TCL735

If there are none, and this feature was created just because it got picked by the developer then please give me some more time to review this. This is low priority at the moment.

Give me at least another week. Possibly two weeks.

TCL735 avatar Jan 24 '21 23:01 TCL735

This is indeed low priority as we work through maps and annotations. Ok to put this on hold until those features land.

timhallinflux avatar Jan 27 '21 16:01 timhallinflux