flux icon indicating copy to clipboard operation
flux copied to clipboard

Custom functions/source libraries

Open OrangeFlag opened this issue 6 years ago • 5 comments

It would be great, if the user could add a custom source and functions in flux. Can you add this feature via go plugin or something like that?

OrangeFlag avatar May 17 '19 19:05 OrangeFlag

@OrangeFlag That is an interesting idea. I saw you closed your PR for Elastic source https://github.com/influxdata/flux/pull/1165. I apologize for not getting to that sooner. Is that something you still want to contribute? Or did you close it for another reason?

nathanielc avatar May 17 '19 19:05 nathanielc

Is that something you still want to contribute?

@nathanielc I still want to contribute elastic source. And if you give me a couple of tips, I will continue to work. For example, is it worth getting rid of external dependencies? Elastic has many types of queries, I implemented only simple queries. Will it be enough? What else, besides tests, should be to merge PR in a master?

OrangeFlag avatar May 17 '19 19:05 OrangeFlag

@OrangeFlag Glad to hear it. I am traveling next week so I won't be able to take a look for a while yet, but yes we will help out with tips/pointers where we can.

For now using the Elastic client is fine as well as supporting only simple queries.

Do you want to reopen that PR?

nathanielc avatar May 17 '19 21:05 nathanielc

I'd still love to see a feature like this. Even if it only worked for pure flux code and didn't support the use of custom Go code at all, just being able to define some custom flux code in one place and then re-use it via import rather than having to inline it into every query you write, would be an enormous quality-of-life improvement.

philomory avatar Feb 09 '21 00:02 philomory

This issue has had no recent activity and will be closed soon.

github-actions[bot] avatar Jul 31 '24 01:07 github-actions[bot]