flux-lsp icon indicating copy to clipboard operation
flux-lsp copied to clipboard

Composition commands should not work on invalid flux

Open rockstar opened this issue 2 years ago • 0 comments

When executing any composition command, we should error if the flux doesn't pass semantic checks. We cannot construct valid AST from invalid AST, and we shouldn't try to construct valid AST in bad semantic graph. The user is presented with proper diagnostics to show what needs to be corrected beforehand, so no extra functionality is needed there.

DOD:

  • composition commands all check to ensure the flux is semantically valid before handling composition tasks, and error when it is invalid

rockstar avatar Nov 01 '22 21:11 rockstar