fluvio
fluvio copied to clipboard
[Bug]: cdk generate project template should refer to fluvio stable release
What happened
cdk generate
fluvio = { git = "https://github.com/infinyon/fluvio", rev = "SHAHASH" }
fluvio-connector-common = { git = "https://github.com/infinyon/fluvio", rev = "SHAHASH", features = ["derive"]}
Expected behavior
The generated project should create
How to reproduce it (as minimally and precisely as possible) Steps to reproduce the behavior:
-
cdk generate <projectname>
-
cat projectname/Cargo.toml
Environment (please complete the following information): cdk
Additional context The immediate fix could be to change the template to refer to a stable fluvio.
fluvio = "0.11"
The Cargo.lock would maintain the specific patch version.
An additional related item to decouple the connector dep references is that fluvio-connector-common also referenced, is not a released crate, so it can't be referenced via crates.io
fwiw fluvio-connector-common
probably / maybe / maybahps could be re-exported via fluvio via additive feature flag e.g.
fluvio = { vers = "X.Y", features = ["connector-common"] }
That way can ensure the compatibility across types etc.
We definitely have a set of options with different tradeoffs to consider. Export as a feature adds adds bulk to the fluvio crate, but is nice that it keeps everything in sync for the end dep user.
Stale issue message
fyi
- #3943
Would be perhaps good to test with a dummy connector that release ref from git works upon stable release.