fluvio icon indicating copy to clipboard operation
fluvio copied to clipboard

[Bug]: cdk generate project template should refer to fluvio stable release

Open digikata opened this issue 1 year ago • 5 comments

What happened

cdk generate generates a project where the Cargo.toml contains fluvio (and fluvio related crate) dependency of:

fluvio = { git = "https://github.com/infinyon/fluvio", rev = "SHAHASH" }
fluvio-connector-common = { git = "https://github.com/infinyon/fluvio", rev = "SHAHASH", features = ["derive"]}

Expected behavior

The generated project should create

How to reproduce it (as minimally and precisely as possible) Steps to reproduce the behavior:

  1. cdk generate <projectname>
  2. cat projectname/Cargo.toml

Environment (please complete the following information): cdk

Additional context The immediate fix could be to change the template to refer to a stable fluvio.

fluvio = "0.11"

The Cargo.lock would maintain the specific patch version.

digikata avatar Dec 18 '23 17:12 digikata

An additional related item to decouple the connector dep references is that fluvio-connector-common also referenced, is not a released crate, so it can't be referenced via crates.io

digikata avatar Dec 18 '23 22:12 digikata

fwiw fluvio-connector-common probably / maybe / maybahps could be re-exported via fluvio via additive feature flag e.g.

fluvio = { vers = "X.Y", features = ["connector-common"] }

That way can ensure the compatibility across types etc.

pinkforest avatar Dec 18 '23 22:12 pinkforest

We definitely have a set of options with different tradeoffs to consider. Export as a feature adds adds bulk to the fluvio crate, but is nice that it keeps everything in sync for the end dep user.

digikata avatar Dec 27 '23 22:12 digikata

Stale issue message

github-actions[bot] avatar Feb 26 '24 11:02 github-actions[bot]

fyi

  • #3943

Would be perhaps good to test with a dummy connector that release ref from git works upon stable release.

pinkforest avatar Apr 14 '24 16:04 pinkforest