fluvio icon indicating copy to clipboard operation
fluvio copied to clipboard

Update syn@1 to syn@2 in fluvio-protocol-derive crate

Open digikata opened this issue 1 year ago • 7 comments

Dependabot identified the need for the dep update https://github.com/infinyon/fluvio/pull/3548

But, the update isn't a simple version change.

digikata avatar Oct 04 '23 19:10 digikata

@matheus-consoli ?

sehz avatar Oct 08 '23 17:10 sehz

We'll have him review if there is a candidate submission unless this is blocking work?

digikata avatar Oct 09 '23 15:10 digikata

not blocker but it would be good to get this done soon

sehz avatar Oct 09 '23 15:10 sehz

hi. new to fluvio here. need to start somewhere I guess. would this be the change ? jai@ubuntu:~/fluvio/crates/fluvio-protocol-derive$ git diff diff --git a/crates/fluvio-protocol-derive/Cargo.toml b/crates/fluvio-protocol-derive/Cargo.toml index db57e918..fde40195 100644 --- a/crates/fluvio-protocol-derive/Cargo.toml +++ b/crates/fluvio-protocol-derive/Cargo.toml @@ -18,7 +18,7 @@ quote = { workspace = true } tracing = { workspace = true }

[dependencies.syn] -version = "1.0.0" +version = "2.0.0" features = ["full"]

Is yes, how do I test pls ? --Jai

jsat97 avatar Oct 17 '23 14:10 jsat97

API for syn has changed, There are tests already https://github.com/infinyon/fluvio/tree/master/crates/fluvio-protocol/tests

sehz avatar Oct 17 '23 14:10 sehz

Similar to this PR https://github.com/infinyon/fluvio/pull/3513

morenol avatar Oct 17 '23 14:10 morenol

@morenol ok. will take a look at that one.

jsat97 avatar Oct 17 '23 16:10 jsat97