fluvio
fluvio copied to clipboard
Update syn@1 to syn@2 in fluvio-protocol-derive crate
Dependabot identified the need for the dep update https://github.com/infinyon/fluvio/pull/3548
But, the update isn't a simple version change.
@matheus-consoli ?
We'll have him review if there is a candidate submission unless this is blocking work?
not blocker but it would be good to get this done soon
hi. new to fluvio here. need to start somewhere I guess. would this be the change ? jai@ubuntu:~/fluvio/crates/fluvio-protocol-derive$ git diff diff --git a/crates/fluvio-protocol-derive/Cargo.toml b/crates/fluvio-protocol-derive/Cargo.toml index db57e918..fde40195 100644 --- a/crates/fluvio-protocol-derive/Cargo.toml +++ b/crates/fluvio-protocol-derive/Cargo.toml @@ -18,7 +18,7 @@ quote = { workspace = true } tracing = { workspace = true }
[dependencies.syn] -version = "1.0.0" +version = "2.0.0" features = ["full"]
Is yes, how do I test pls ? --Jai
API for syn has changed, There are tests already https://github.com/infinyon/fluvio/tree/master/crates/fluvio-protocol/tests
Similar to this PR https://github.com/infinyon/fluvio/pull/3513
@morenol ok. will take a look at that one.