fluvio icon indicating copy to clipboard operation
fluvio copied to clipboard

`fluvio cluster delete` should prompt with cluster and endpoint name confirmation

Open digikata opened this issue 1 year ago • 4 comments

Currently the user can delete an unintended cluster with fluvio cluster delete because the cluster the profile is pointing to is not reported.

Change: Add an interaction to print the current cluster and endpoint and ask for confirmation. The user is asked to type the name of the cluster.

$ fluvio cluster delete
WARNING: You are about to delete CLUSTER/ENDPOINT. This operation is irreversible 
and the data stored in your cluster will be permanently lost.

Please type the cluster name to confirm: CLUSTER <enter> (to confirm) / or CTRL-C (to cancel)
Your cluster CLUSTER has been deleted

Note:

  • add -f \ --force option to bypass the prompt for CI and automation tool

reference: fluvio profile list returns a table of PROFILE, CLUSTER, ENDPOINT logic to retrieve current cluster/endpoint can be found with that command logic

digikata avatar Aug 25 '23 08:08 digikata

Hey @digikata I was dealing with #3481 but I didn't got follow up yet. Can I take this one meanwhile?

demfabris avatar Aug 29 '23 17:08 demfabris

@demfabris, feel free to take this item. Please note the update in the issue definition.

ajhunyady avatar Aug 30 '23 19:08 ajhunyady

should add a --force option to bypass the prompt for CI and automation tool

sehz avatar Aug 30 '23 19:08 sehz

Stale issue message

github-actions[bot] avatar Oct 30 '23 11:10 github-actions[bot]

Hi! I tried to contribute on this issue. Please let me know if there is any feedback :)

PanGan21 avatar May 28 '24 14:05 PanGan21

Hi @PanGan21, thanks for the contribution! We'll definitely take a look at it

digikata avatar May 28 '24 15:05 digikata

Solved w/ https://github.com/infinyon/fluvio/pull/4034 from @PanGan21

digikata avatar Jun 03 '24 15:06 digikata