fluvio
fluvio copied to clipboard
[CI] Move build artifact publish steps
Currently we create and push these artifacts from staging
. Since we use Bors to perform merges, that means each new build attempt has a new git commit that gets built into the binaries.
If a staging CI job fails, we may not be able to continue from the same commit. And staging builds fail often enough that we should take it into consideration.
We should have a new workflow that runs on push event to the master
branch. The final rust binaries and docker images should originate the commits that correlate to master
.
https://github.com/infinyon/fluvio/blob/ef8d019080e10a748efb6dac75a3bbfcd1294f84/.github/workflows/ci.yml#L115
https://github.com/infinyon/fluvio/blob/ef8d019080e10a748efb6dac75a3bbfcd1294f84/.github/workflows/ci.yml#L955
https://github.com/infinyon/fluvio/blob/ef8d019080e10a748efb6dac75a3bbfcd1294f84/.github/workflows/ci.yml#L1006
https://github.com/infinyon/fluvio/blob/ef8d019080e10a748efb6dac75a3bbfcd1294f84/.github/workflows/ci.yml#L1027
https://github.com/infinyon/fluvio/blob/ef8d019080e10a748efb6dac75a3bbfcd1294f84/.github/workflows/ci.yml#L1044
New workflow doesn't have to rebuild artifacts. Can use binaries from staging build since we are using bors to guarantee order