fluvio icon indicating copy to clipboard operation
fluvio copied to clipboard

Published 20 hours ago • verified publisher icon infinyon

Move CRDs from templates/ to crds/

Open tothandras opened this issue 2 years ago • 8 comments

Is there any reason not to move CRDs to the crds/ folder in fluvio-sys? See: https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you

tothandras avatar Jun 27 '22 19:06 tothandras

This makes sense. But if we are going to do this, let's remove crd prefix from the file name since they are redundant

sehz avatar Jun 27 '22 22:06 sehz

CI still fails. Can you find out why it is failing?

sehz avatar Jun 29 '22 18:06 sehz

bors r+

sehz avatar Jul 26 '22 17:07 sehz

CI still failed. Can you check if inline helm still works? https://github.com/infinyon/fluvio/blob/master/k8-util/helm/Makefile

sehz avatar Jul 26 '22 17:07 sehz

bors r-

sehz avatar Jul 26 '22 17:07 sehz

Canceled.

bors[bot] avatar Jul 26 '22 17:07 bors[bot]

Ensure upgrade helm upgrade works.

sehz avatar Jul 26 '22 18:07 sehz

@sehz I'm running helm install / upgrade without issues, I'll check the test case.

tothandras avatar Jul 26 '22 18:07 tothandras

Stale pull request message

github-actions[bot] avatar Oct 10 '22 11:10 github-actions[bot]