eightshift-libs icon indicating copy to clipboard operation
eightshift-libs copied to clipboard

Published 20 hours ago • verified publisher icon infinum

PHP 8+ support

Open dingo-d opened this issue 2 years ago • 1 comments

Describe your feature request

We should start checking for PHP 8+ compatibility/issues in the libs.

Describe the solution you'd like

  1. Add GH Actions matrix checks, with allowed failures for PHP 8+ (since we are still not supporting them, it's ok that they fail)
  2. Modify the phpcs config so that the supported version is upped to PHP8
  3. Check if there are any forbidden keywords used as method arguments
  4. Consolidate and agree on method argument naming (after PHP 8, any change in argument name will be a BC break!)
  5. Update code to be written using PHP8 syntax with a fallback for PHP 7.4 version where possible
  6. Test everything

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in this repo.

Yes

Please confirm that you have searched in our documentation and couldn't find the answer.

Yes

dingo-d avatar Jul 20 '22 09:07 dingo-d

We have started working on this support all fixes are located in this develop-php8 branch

iruzevic avatar Oct 26 '23 06:10 iruzevic

this is done in the latest release

iruzevic avatar Jun 05 '24 11:06 iruzevic