eightshift-forms icon indicating copy to clipboard operation
eightshift-forms copied to clipboard

Libs 8.0.0 release

Open iruzevic opened this issue 1 year ago • 3 comments
trafficstars

Updated

  • Eightshift-forms-utils to the latest version 2.0.0.
  • @infinum/eightshift-libs to the latest version 8.0.0.
  • @infinum/eightshift-frontend-libs to the latest version 12.0.0.

Removed

  • All Data are not loaded from utils lib.
  • Top bar no longer supports listing all forms items for faster loading.
  • src/Exception/MissingFilterInfoException.php because it is not used anymore.

Added

  • New Caching service for manifest data.

Fixed

  • Custom post type labels are not translatable.

Changed

  • Filter script_dependency_theme is now script_dependency_theme_captcha.

TODO

  • [x] Changelog
  • [ ] Release
  • [ ] Composer remove temp items

iruzevic avatar Apr 29 '24 21:04 iruzevic

What is the purpose of the setCache empty file? Does it have to be committed? Accident commit, I have remove it.

Changed the getManifest to getManifestDir - how will this impact userland code? Is getManifest used, for instance, in projects? If so, will updating to this version break this implementation? If the answer is yes, the version of the forms should be updated to 3.0.0 notifying users of a BC break.

As these forms change, this will impact users in no way. As the addon has its own libs and we are not implementing any breaking changes to the user's implementation in the project, so I don't see any need to bump the forms to 3.0.0

Also, I've left a couple of suggestions regarding naming, and some potentially misnamed methods.

tnx, will fix it

iruzevic avatar May 06 '24 07:05 iruzevic

As these forms change, this will impact users in no way. As the addon has its own libs and we are not implementing any breaking changes to the user's implementation in the project, so I don't see any need to bump the forms to 3.0.0

So the changes in the blocks won't affect the existing blocks on the existing forms? I'm just wondering if this will have any impact on the custom blocks that can be added and are depending on the old utils.

dingo-d avatar May 06 '24 07:05 dingo-d

As these forms change, this will impact users in no way. As the addon has its own libs and we are not implementing any breaking changes to the user's implementation in the project, so I don't see any need to bump the forms to 3.0.0

So the changes in the blocks won't affect the existing blocks on the existing forms? I'm just wondering if this will have any impact on the custom blocks that can be added and are depending on the old utils.

As the forms are now for the users to develop on like Boilerplate is, what ever we do on the internal logic will not affect the user in any way. For the forms a major update will be is the users needs to make any migrations or some corrections in the filters. So I would say that we are on with staying on the 2+ version

iruzevic avatar May 06 '24 07:05 iruzevic