datx icon indicating copy to clipboard operation
datx copied to clipboard

Better handling of jsonapi-angular package.json

Open fvoska opened this issue 2 years ago • 1 comments

Relevant version

  • [ ] 0.x
  • [ ] 1.x
  • [X] 2.x

Relevant libraries

  • [ ] utils
  • [ ] core
  • [ ] network
  • [ ] jsonapi
  • [X] jsonapi-angular

Breaking change

No

Description

Currently, there are multiple package.json files in the repository:

  • Monorepo setup - https://github.com/infinum/datx/blob/master/package.json
  • Angular package - https://github.com/infinum/datx/blob/master/packages/datx-jsonapi-angular/package.json
  • Angular lib project - https://github.com/infinum/datx/blob/master/packages/datx-jsonapi-angular/projects/datx-jsonapi-angular/package.json

We can probably simplify the whole setup by removing one of the two angular packages (probably projects/datx-jsonapi-angular/package.json) or use them differently during the build process

fvoska avatar Jun 13 '22 09:06 fvoska

https://github.com/infinum/datx/blob/master/packages/datx-jsonapi-angular/package.json and https://github.com/infinum/datx/blob/master/packages/datx-jsonapi-angular/projects/datx-jsonapi-angular/package.json have been updated in #966 to make the use cases for these two separate package.json files clearer. projects/datx-jsonapi-angular/package.json is used for publishing to npm and has all the required metadata for NPM, package.json is used for development.

fvoska avatar Jun 24 '22 14:06 fvoska