thesis-phoenix icon indicating copy to clipboard operation
thesis-phoenix copied to clipboard

Images uploaded with Thesis aren't cached properly.

Open silasjmatson opened this issue 8 years ago • 1 comments

I'm not fully sure this is a thesis issue, but it needs more investigation.

Images were being served with Cache-Control:max-age=0, private, must-revalidate

We should either allow the Cache-Control header to be configured w/in thesis, or serve them with a Cache-Control header similar to normal assets, or set a reasonable max-age value.

silasjmatson avatar Jul 20 '17 18:07 silasjmatson

One solution would be to set the 'Cache-Control' headers here: https://github.com/infinitered/thesis-phoenix/blob/master/lib/thesis/api_controller.ex#L57-L61

silasjmatson avatar Jul 20 '17 20:07 silasjmatson