reactotron icon indicating copy to clipboard operation
reactotron copied to clipboard

fix: BigInts on hermes android were crashing during serialization for reactotron

Open markrickert opened this issue 1 year ago • 1 comments

Please verify the following:

  • [x] yarn build-and-test:local passes
  • [x] I have added tests for any new features, if relevant
  • [x] README.md (or relevant documentation) has been updated with your changes

Describe your PR

I though I had fixed this but we got more reports from the community that it was still broken on android.

I added a few new buttons to the example app and was able to reproduce the crash on my android emulator on expo 50 / rn 0.73.6.

With these changes, bigints show up properly in the reactotron app. Closes #1436

33A78A6F-C83B-4CA6-BDA2-8F3F6E1A5B16-75409-00059A133DB30F84

markrickert avatar Aug 14 '24 18:08 markrickert

thanks a lot for the fix, try with your changes for my project on android. working fine

ivannzme avatar Oct 02 '24 01:10 ivannzme