ignite icon indicating copy to clipboard operation
ignite copied to clipboard

fix(cli): remove sharp dependency

Open frankcalise opened this issue 8 months ago • 0 comments

Please verify the following:

  • [ ] yarn test jest tests pass with new tests, if relevant
  • [ ] README.md has been updated with your changes, if relevant

Describe your PR

image

  • This is the start of removing sharp as a dependency to the CLI which has been linked to many issues: #2483, #2518
  • Dimensions are now acquired via buffer-image-size as sharp-cli doesn't allow for printing metadata yet (see old PR)
  • Existing sharp commands are now applied via sharp-cli

Still Pending

  • Come up with a temp file solution since we can't use buffers anymore
  • Other ideas to not have to use sharp-cli at all since maybe that will block bun adoption still? (although unsure)

frankcalise avatar Oct 12 '23 05:10 frankcalise