protostream icon indicating copy to clipboard operation
protostream copied to clipboard

IPROTO-155 Reduce FileDescriptor memory usage

Open tristantarrant opened this issue 2 years ago • 1 comments

https://issues.redhat.com/browse/IPROTO-155

Parse annotations eagerly to avoid keeping them around.

tristantarrant avatar Jan 24 '24 16:01 tristantarrant

Sorry @tristantarrant I only noticed running this patch on current Infinispan main, that there are some cases where the annotations field is filled and processedAnnotations not. This probably could be an issue for the remote query code. Full story here => https://infinispan.zulipchat.com/#narrow/stream/118645-infinispan/topic/pr.20queue/near/420641654.

An idea to keep the optimization, is to fill the annotations list only if:

annotations ⊈ processedAnnotations

at the end of processAnnotations methods. WTDY?

fax4ever avatar Feb 09 '24 12:02 fax4ever