inferno-core icon indicating copy to clipboard operation
inferno-core copied to clipboard

FI-3182 Inferno execute unified short ids option

Open Shaumik-Ashraf opened this issue 1 year ago • 1 comments

Summary

Create command line option that allows for unified short ids --short-ids (alias: -r)

Testing Guidance

  1. checkout this branch
  2. bundle exec inferno services start
  3. verify old behavior
bundle exec inferno execute --suite infra_test --groups 1 --tests 4.01 --inputs suite_input:a outer_group_input:b inner_group_input:c test_input:d external_test1_input:asdf external_inner_group_input:asdf external_outer_group_input:asdf
  1. verify new behavior
bundle exec inferno execute --suite infra_test --short-ids 1 4.01 --inputs suite_input:a outer_group_input:b inner_group_input:c test_input:d external_test1_input:asdf external_inner_group_input:asdf external_outer_group_input:asdf
  1. this should raise an exception to prevent running 1.01 twice
bundle exec inferno execute --suite dev_validator -r 1 1.01 -i "url:https://hapi.fhir.org/baseR4" patient_id:1234321

Shaumik-Ashraf avatar Oct 04 '24 22:10 Shaumik-Ashraf

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.08%. Comparing base (5b83481) to head (805f4a9). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage   84.08%   84.08%           
=======================================
  Files         261      261           
  Lines       11392    11392           
  Branches     1252     1252           
=======================================
  Hits         9579     9579           
  Misses       1803     1803           
  Partials       10       10           
Flag Coverage Δ
backend 92.18% <ø> (ø)
frontend 79.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '24 22:10 codecov[bot]

Updated testing guidance

  1. Checkout this branch
  2. bundle exec inferno services start
  3. verify old behavior
bundle exec inferno execute --suite infra_test --groups 1 --tests 4.01 --inputs suite_input:a outer_group_input:b inner_group_input:c test_input:d
  1. verify new behavior
bundle exec inferno execute --suite infra_test --short-ids 1 4.01 --inputs suite_input:a outer_group_input:b inner_group_input:c test_input:d
  1. this should ~~raise an exception to prevent running 1.01 twice~~ now work, and show two results from 1.01 (one from group 1, and one from the test)
bundle exec inferno execute --suite dev_validator -r 1 1.01 -i "url:https://hapi.fhir.org/baseR4" patient_id:1234321

Shaumik-Ashraf avatar Oct 18 '24 14:10 Shaumik-Ashraf

Okay behavior should be correct now

Shaumik-Ashraf avatar Oct 24 '24 15:10 Shaumik-Ashraf