eslint-plugin-typescript-sort-keys icon indicating copy to clipboard operation
eslint-plugin-typescript-sort-keys copied to clipboard

Published 20 hours ago • verified publisher icon infctr

Consider sorting other types of enums?

Open zachbryant opened this issue 1 year ago • 2 comments

I'm finalizing my branch before PR for #26 and I noticed the linter works just fine on other kinds of enums. For example, the test case enum U {c=1<<1, b, a} has no special work required to sort. Is there a specific reason to only sort string enums? If not, I'd propose changing the rule to just enum instead of string-enum.

I figured something such as changing rule names should be part of a major version change, might as well lump it in with the same PR

zachbryant avatar Dec 10 '23 00:12 zachbryant

Hey, @zachbryant Thank you for your time and effort working on the issue! Let's add a new rule for that matter to make it backwards compatible, WDYT?

infctr avatar Dec 10 '23 10:12 infctr

Sounds good to me

zachbryant avatar Dec 10 '23 21:12 zachbryant